xymond: restrict the "config" command to admin/config senders#1
Open
SoundGoof wants to merge 1 commit into
Open
xymond: restrict the "config" command to admin/config senders#1SoundGoof wants to merge 1 commit into
SoundGoof wants to merge 1 commit into
Conversation
SoundGoof
force-pushed
the
feature/xymond-config-senders
branch
3 times, most recently
from
4e3cb08 to
0ac73ee
Compare
--config-senders is independent of --admin-senders. Unset (default), "config" and "query" are gated by --status-senders, same as before this option existed. Once set, only hosts in --config-senders may send either command, and --status-senders no longer applies to them. Adds tests/server/config-senders-optin.sh to guard this contract.
SoundGoof
force-pushed
the
feature/xymond-config-senders
branch
from
0ac73ee to
4ee7f66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "config" command served *.cfg files from etc/ to any host, since it was gated by the default-open statussenders ACL. Require the sender be in admin-senders (as drop/rename already are) or a new, separate config-senders list, so distributed tools (e.g. a remote xymonnet poller) can be authorized to fetch config files without also getting admin-senders' drop/rename rights.