Starlarkify default_features_and_action_configs#764
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
dzbarsky
changed the title
Compute _default_features_and_action_configs in create_cc_toolchain_config_info after legacy feature and action config injection. Expose the same list through CcToolchainInfo and use it in configure_features instead of calling CcToolchainFeatures.default_features_and_action_configs().
dzbarsky
force-pushed
the
codex/starlarkify-default-features-and-action-configs
branch
from
299655a to
2907937
Compare
lilygorsheneva
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute
CcToolchainConfigInfo._default_features_and_action_configsincreate_cc_toolchain_config_infoafter legacy feature and action-config injection, preserving the native feature-before-action-config order.CcToolchainInfoexposes the same list toconfigure_features, which removes the call toCcToolchainFeatures.default_features_and_action_configs().