Cache rule feature lists#767
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.featuresandctx.disabled_featuresallocate a new list on every access. Cache those lists incc_binary,cc_library,objc_library, andobjc_import, then pass the cached lists through the existing feature-configuration helpers.This reduces
ctx.featuresaccesses from up to five to one forcc_binary/cc_test, from up to four to one forcc_library, and reduces both property accesses from four to one forobjc_libraryand from two to one forobjc_import. Optional helper arguments preserve behavior for existing external callers.Validation
buildifier -mode=checkon all changed Starlark filesbazel test --jobs=4 --test_output=errors //tests/cc/common:cc_common_tests //tests/cc/common:cc_binary_configured_target_tests //tests/cc/common:cc_objc_library_configured_target_tests