Add DTX support#1
Open
mugabe wants to merge 3 commits into
Open
Conversation
dtinth
reviewed
Apr 17, 2018
Member
dtinth
left a comment
dtinth
left a comment
There was a problem hiding this comment.
Thanks for PR, here is some preliminary review.
| return '12K' | ||
| } | ||
| else { | ||
| return '8K' |
Member
There was a problem hiding this comment.
About key mode, since these represent drums rather than keys, should they be named 12D/8D, drums8/drums12, or DTX/DTXG?
Author
There was a problem hiding this comment.
Good idea. Will change to 12D/8D.
| notes: notes, | ||
| timing: timing, | ||
| scratch: false, | ||
| keys: getKeys(chart, 'dtx'), |
Member
There was a problem hiding this comment.
Since getKeys function has potential to grow, may be better to use named parameter: getKeys(chart, { format: 'dtx' }), like bms-js.
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I specified my actual branch for bms dependency, as version was not bumped yet.