BIP 54: progress to Complete#2172
Conversation
335850a to
c476556
Compare
murchandamus
left a comment
There was a problem hiding this comment.
I had another look at test vectors and reference implementation. Concerns and issues have been discussed on the mailing list and are documented in the proposal. LGTM.
|
process wise this seems like a fast merge |
|
This PR was just a Metadata update and a link update for the reference implementation. Relevant section of BIP3:
@JeremyRubin: By the way, I asked a couple days ago, whether you would agree that CTV should be Complete rather than Draft. I’m also waiting for your sign-off to publish OP_TWEAKADD. |
|
I'm surprised a consensus change bip was advanced to complete while not including activation parameters. Is the idea that activation parameters would come under the "minimal and interfere as little as possible with ongoing adoption" clause of allowed modifications to a complete bip, or will activation params for bip54 go in a separate bip (similar to 448 vs 446/348/349?), or something else? |
I have concluded all planned work on BIP 54. I believe it represents a net improvement and is ready for adoption by the Bitcoin community. As per BIP 3, this updates its status to Complete.