PM-26577: Feat: Support multiple schemes for Duo, WebAuthn, and SSO callbacks#6339
Conversation
| .getEncoder() | ||
| .encodeToString(json.toString().toByteArray(Charsets.UTF_8)) | ||
| val parentParam = URLEncoder.encode(CALLBACK_URI, "UTF-8") | ||
| val parentParam = URLEncoder.encode(callbackUri, "UTF-8") |
There was a problem hiding this comment.
This parent param is required by the WebAuthn Connector but it does not really use the value.
I have an open question about what I should be sending here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
==========================================
- Coverage 86.66% 86.43% -0.23%
==========================================
Files 901 876 -25
Lines 64860 63893 -967
Branches 9260 9248 -12
==========================================
- Hits 56211 55229 -982
- Misses 5464 5480 +16
+ Partials 3185 3184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
795738e to
60679da
Compare
|
Great job! No new security vulnerabilities introduced in this pull request |
60679da to
fc73da8
Compare
fc73da8 to
1174c47
Compare
1174c47 to
d702bbf
Compare
ffb771d to
375d447
Compare
375d447 to
3e821aa
Compare
|
Claude finished @david-livefront's task in 4m 20s —— View job Code Review SummaryPR: PM-26577: Support multiple schemes for Duo, WebAuthn, and SSO callbacks OverviewThis PR activates HTTPS app links for Duo, WebAuthn, and SSO authentication callbacks on known environments (US, EU, Internal), replacing the Changes Reviewed
Findings✅ No new issues found in this PR's changed code.
Pre-existing Issue (not in this PR's diff)
This matters for this PR because it activates the Reviewed by Claude Code -- Re-review after rebase onto main (bb33db6). No issues in the PR diff itself. |
3e821aa to
64c8a7e
Compare
64c8a7e to
59c70c1
Compare
9b129e3 to
26c74a3
Compare
26c74a3 to
bb33db6
Compare
bb33db6 to
db7ae1c
Compare
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR completes the planned migration from custom-scheme callbacks ( Code Review DetailsNo findings. Notes (informational, not blocking):
|
db7ae1c to
99e58d1
Compare
99e58d1 to
5ccc8a8
Compare
|
Thanks @vvolkgang |

🎟️ Tracking
PM-26577
📔 Objective
This PR updates the Duo and WebAuthn logic to send the appropriate deeplink scheme data.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes