fix(projects): show create menu when no projects exist - #4842
Open
mijanx wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jan <13257134+mijanx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
On a relay with zero projects, the Projects view returned the
No projects yetempty state before rendering the normal Projects shell. That shell contains the only project-creation affordance: the+create menu.This created a chicken-and-egg failure: users could not create their first project from the desktop UI because the create button only appeared after at least one project already existed. Creating a project out-of-band made the button appear.
Implementation
+create menu mounted when the project list is empty.No projects yetstate inside the shell's content area instead of returning it as the entire view.No follow-up work is deferred.
Related issue
Fixes #3504. Also addresses #2585 and #2622.
Testing
pnpm --dir desktop exec playwright test tests/e2e/project-commit-detail.spec.ts --project=smoke -g "empty projects state keeps project creation available"just ciNo projects yetis shown.+button is visible.Before
With zero projects, only the empty state rendered. There was no Projects header, toolbar, or
+button, so the first project could not be created from the UI.After
The standard Projects shell remains visible around the same empty state. The
+menu is available and exposes Project, allowing creation of the first project.