[codex] Add Codex workspace cron scheduler#9654
Conversation
6efd720 to
7d595b6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8c5188db0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (contains-any? (:day-of-month spec) (.getDayOfMonth zdt)) | ||
| (contains-any? (:month spec) (.getMonthValue zdt)) | ||
| (or (contains-any? (:day-of-week spec) dow) | ||
| (and (zero? dow) (contains-any? (:day-of-week spec) 7)))))) |
There was a problem hiding this comment.
Honor cron's DOM/DOW OR semantics
For schedules that restrict both day-of-month and day-of-week, this requires both fields to match because due? is inside a single and. The skill documents support for standard 5-field cron expressions, where these two fields are matched with OR semantics, so a schedule like 0 9 1 * 1 should run on the 1st of each month and every Monday but will only run when the 1st is a Monday. This silently skips expected runs for otherwise-valid cron schedules.
Useful? React with 👍 / 👎.
Summary
/opt/codex-workspace/cron/home/boxp/.codex-cron/jobs.edncodex-workspace-cronskill/helper to CRUD the live home registry instead ofboxp/loliceConfigMap/CronJob manifestsRelated
Validation
bash -n docker/codex-workspace/entrypoint.shbash -n docker/codex-workspace/cron/run-codex-cron.shbb docker/codex-workspace/skills/codex-workspace-cron/scripts/codex_cron_jobs.bb --root <tmp> listadd/show/update/enable/disable/deleteagainst a temporary home registryCODEX_CRON_ROOT=<tmp> timeout 2s bb docker/codex-workspace/cron/scheduler.bbgit diff --check