Fix flaky tests

[willnet]

Summary

Fix an order-dependent PostgreSQL test failure caused by the upsert_all test leaving the users primary key sequence out of sync.

Details

The upsert_all with different value formats works correctly test inserts rows with explicit primary keys:

{ id: 1, ... }
{ id: 2, ... }
{ id: 3, ... }

On PostgreSQL, inserting or upserting rows with explicit IDs does not advance the table’s primary key sequence. As a result, later tests that create User records without specifying an ID can receive an already-used ID from the sequence, causing errors like:

PG::UniqueViolation: duplicate key value violates unique constraint "users_pkey"

This failure depends on randomized test order. In the failing CI run, the upsert_all test ran before tests that performed normal User.create! / save! calls.

Fix

Wrap the upsert_all test in an ensure block and reset the primary key sequence afterward when the adapter supports it:

User.connection.reset_pk_sequence!(User.table_name) if User.connection.respond_to?(:reset_pk_sequence!)

Using ensure makes sure the sequence is reset even if the test fails partway through, preventing this test from leaking database state into later tests.

Verification

Reproduced with PostgreSQL using the CI seed:

POSTGRES_USER=postgres \
POSTGRES_PASSWORD=postgres \
DB=postgresql \
bundle exec ruby -w -Ilib:test test/activerecord_test.rb --seed 40802

result example

  1) Error:
ActiveRecordTest#test_0028_stores multiple value passed passed to new:
ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "users_pkey"
DETAIL:  Key (id)=(2) already exists.

# … snip …

  2) Error:
ActiveRecordTest#test_0044_does not change by the practical same value:
ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "users_pkey"
DETAIL:  Key (id)=(3) already exists.
# … snip …