Fix baseline suppression for same resources in different directories - #7624
Open
haneul-24 wants to merge 1 commit into
Open
Fix baseline suppression for same resources in different directories#7624haneul-24 wants to merge 1 commit into
haneul-24 wants to merge 1 commit into
Conversation
Signed-off-by: unknown <sej1306kook@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes: #7486
This fixes an issue where baseline matching only checked the resource and check ID. Because of that, resources with the same name in different directories could be treated as the same finding and get suppressed.
I added the file path to the comparison so only the matching file is suppressed.
I also added a regression test to cover this case.
Testing