workflows: bump BITCOIND_VERSION to 29#1056
Open
mohamedawnallah wants to merge 1 commit into
Open
Conversation
Roasbeef
requested changes
Sep 6, 2025
Roasbeef
left a comment
Member
There was a problem hiding this comment.
Changes look good, but the unit tests look to be failing.
FWIW, we've typically relied on the lnd lnwallet integration tests, but I do support updating these. I think we might be using some older commands/configs that have been deprecated.
yyforyongyu
reviewed
Sep 8, 2025
yyforyongyu
left a comment
Collaborator
There was a problem hiding this comment.
Don't do it yet - let's finalize our CI pipeline and run tests against multiple versions of bitcoins first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.