multi: fix linter errors from account manager interface#1084
Merged
yyforyongyu merged 5 commits intoSep 29, 2025
Conversation
They are too noisy at the moment, and we will bring them back when we implement `Store` interface as the current `addrStore` returns a structured error, making it hard to check in the test once wrapped.
Run `make lint` to auto fix linter errors.
yyforyongyu
force-pushed
the
fix-linter-errors
branch
from
b7e6400 to
f6cf57c
Compare
7 tasks
yyforyongyu
force-pushed
the
fix-linter-errors
branch
from
f6cf57c to
e6c952f
Compare
mohamedawnallah
approved these changes
Sep 29, 2025
Contributor
|
@yyforyongyu - Do we need second reviewer on this one? It seems they are just fixing linting issues. I am checking out benchmarking PRs for account manager series and linting issues arising against interface-wallet (btw thanks for rebasing!) |
Collaborator
Author
Ok given this is merged to a side branch, and it's just linter fix, will merge. |
Collaborator
|
Ack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all the linter errors so the base branch
interface-wallet#1083 can pass the CI checks.