wallet: SQL-only signer account-secret fallback

.gemini/config.yaml

@@ -33,4 +33,4 @@ code_review:
 
 # List of glob patterns to ignore (files and directories).
 # Type: array of string, default: [].
-ignore_patterns: []
+ignore_patterns: ["deprecated.go"]

.gemini/styleguide.md

@@ -1,4 +1,4 @@
-# LND Style Guide
+# Btcwallet Style Guide
 
 ## Code Documentation and Commenting
 
@@ -9,7 +9,7 @@
 - Unit tests must always use the `require` library. Either table driven unit 
   tests or tests using the `rapid` library are preferred. 
 - The line length MUST NOT exceed 80 characters, this is very important. 
-  You must count the Golang indentation (tabulator character) as 8 spaces when 
+  You must count the Golang indentation (tabulator character) as 4 spaces when 
   determining the line length. Use creative approaches or the wrapping rules 
   specified below to make sure the line length isn't exceeded.
 - Every function must be commented with its purpose and assumptions.
@@ -151,7 +151,7 @@ if amt < 546 {
 ### 80 character line length
 
 - Wrap columns at 80 characters.
-- Tabs are 8 spaces.
+- Tabs are 4 spaces.
 
 **WRONG**
 ```go

.github/workflows/main.yml

@@ -30,6 +30,8 @@ env:
   BITCOIND_VERSION: '22.0'
   BITCOIND_IMAGE: 'lightninglabs/bitcoin-core'
 
+  BTCD_VERSION_LATEST: v0.25.0
+
 jobs:
   ########################
   # Format, compileation and lint check
@@ -63,6 +65,15 @@ jobs:
       - name: Check RPC format
         run: make rpc-check
 
+      - name: Check generated SQL code is up-to-date
+        run: make sqlc-check
+
+      - name: Check SQL formatting
+        run: make sql-format-check
+
+      - name: Check SQL linting
+        run: make sql-lint-check
+
       - name: compile code
         run: go install -v ./...
 
@@ -112,28 +123,29 @@ jobs:
     steps:
       - name: extract bitcoind from docker image
         run: |-
-          docker pull ${{ env.BITCOIND_IMAGE }}:${{ env.BITCOIND_VERSION }}
-          CONTAINER_ID=$(docker create ${{ env.BITCOIND_IMAGE }}:${{ env.BITCOIND_VERSION }})
-          sudo docker cp $CONTAINER_ID:/opt/bitcoin-${{ env.BITCOIND_VERSION }}/bin/bitcoind /usr/local/bin/bitcoind
+          IMAGE=${{ env.BITCOIND_IMAGE }}:${{ env.BITCOIND_VERSION }}
+          docker pull $IMAGE
+
+          BIN_PATH=$(docker run --rm --entrypoint sh $IMAGE -c '
+            command -v bitcoind ||
+            find /opt /usr -type f -name bitcoind 2>/dev/null | head -n 1
+          ')
+          if [ -z "$BIN_PATH" ]; then
+            echo "could not locate bitcoind in $IMAGE" >&2
+            exit 1
+          fi
+
+          CONTAINER_ID=$(docker create $IMAGE)
+          sudo docker cp $CONTAINER_ID:$BIN_PATH /usr/local/bin/bitcoind
           docker rm $CONTAINER_ID
+          bitcoind --version
 
       - name: git checkout
         uses: actions/checkout@v5
 
       - name: Clean up runner space
         uses: ./.github/actions/cleanup-space
 
-      - name: go cache
-        uses: actions/cache@v4
-        with:
-          path: /home/runner/work/go
-          key: btcwallet-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            btcwallet-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
-            btcwallet-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ github.job }}-
-            btcwallet-${{ runner.os }}-go-${{ env.GO_VERSION }}-
-            btcwallet-${{ runner.os }}-go-
-
       - name: setup go ${{ env.GO_VERSION }}
         uses: actions/setup-go@v5
         with:
@@ -143,9 +155,225 @@ jobs:
         run: make ${{ matrix.unit_type }}
 
       - name: Send coverage
-        uses: shogo82148/actions-goveralls@v1
+        uses: coverallsapp/github-action@v2
         if: matrix.unit_type == 'unit-cover'
         continue-on-error: true
         with:
-          path-to-profile: coverage.txt
+          file: coverage.txt
+          flag-name: unit
+          format: golang
           parallel: true
+
+  ########################
+  # run integration tests (SQLite + Postgres)
+  ########################
+  itest-db:
+    name: ${{ matrix.db }} itest (${{ matrix.race && 'race' || 'cover' }})
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        db: [sqlite, postgres]
+        race: [false, true]
+    steps:
+      - name: git checkout
+        uses: actions/checkout@v5
+
+      - name: Clean up runner space
+        uses: ./.github/actions/cleanup-space
+
+      - name: setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
+
+      - name: run ${{ matrix.db }} itest-db (coverage)
+        if: ${{ !matrix.race }}
+        run: make itest-db db=${{ matrix.db }} cover=1 verbose=1
+
+      - name: run ${{ matrix.db }} itest-db-race
+        if: matrix.race
+        run: make itest-db-race db=${{ matrix.db }} verbose=1
+
+      - name: Upload coverage to Coveralls
+        uses: coverallsapp/github-action@v2
+        if: ${{ !matrix.race }}
+        continue-on-error: true
+        with:
+          file: coverage-itest-${{ matrix.db }}.txt
+          flag-name: itest-db-${{ matrix.db }}
+          format: golang
+          parallel: true
+
+  ########################
+  # Run bwtest integration tests against each supported chain backend.
+  #
+  # These jobs currently use kvdb only. Database expansion is planned via a
+  # separate matrix in a future change.
+  ########################
+  itest-btcd:
+    name: itest btcd
+    runs-on: ubuntu-latest
+    steps:
+      - name: git checkout
+        uses: actions/checkout@v5
+
+      - name: Clean up runner space
+        uses: ./.github/actions/cleanup-space
+
+      - name: setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
+
+      - name: add go bin to PATH
+        run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+
+      - name: install btcd ${{ env.BTCD_VERSION_LATEST }}
+        run: go install -v github.com/btcsuite/btcd@${{ env.BTCD_VERSION_LATEST }}
+
+      - name: check btcd version
+        run: btcd --version
+
+      # The btcd backend job runs btcd for both the shared miner and the chain
+      # backend under test.
+      - name: run itest (btcd, kvdb)
+        run: make itest chain=btcd db=kvdb
+
+      - name: upload itest logs
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: itest-logs-btcd
+          path: itest/test-logs
+          retention-days: 5
+
+  ########################
+  # Run bwtest integration tests with the neutrino backend.
+  #
+  # Job flow:
+  # - Install btcd `${{ env.BTCD_VERSION_LATEST }}`.
+  # - Use btcd as the shared miner for the suite.
+  # - Run `make itest chain=neutrino db=kvdb` so wallets use the in-process
+  #   neutrino backend while blocks/peers come from btcd.
+  ########################
+  itest-neutrino:
+    name: itest neutrino
+    runs-on: ubuntu-latest
+    steps:
+      - name: git checkout
+        uses: actions/checkout@v5
+
+      - name: Clean up runner space
+        uses: ./.github/actions/cleanup-space
+
+      - name: setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
+
+      - name: add go bin to PATH
+        run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+
+      - name: install btcd ${{ env.BTCD_VERSION_LATEST }}
+        run: go install -v github.com/btcsuite/btcd@${{ env.BTCD_VERSION_LATEST }}
+
+      - name: check btcd version
+        run: btcd --version
+
+      # Neutrino runs in-process, but it still relies on the shared btcd miner
+      # for chain data and peer connectivity.
+      - name: run itest (neutrino, kvdb)
+        run: make itest chain=neutrino db=kvdb
+
+      - name: upload itest logs
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: itest-logs-neutrino
+          path: itest/test-logs
+          retention-days: 5
+
+  ########################
+  # Run bwtest integration tests with the bitcoind backend.
+  #
+  # Job flow:
+  # - Install btcd `${{ env.BTCD_VERSION_LATEST }}` as the shared miner.
+  # - Run a matrix over bitcoind versions `30` (latest) and `28` (older).
+  # - Extract each matrix binary from the docker image and run
+  #   `make itest chain=bitcoind db=kvdb`.
+  ########################
+  itest-bitcoind:
+    name: itest bitcoind (v${{ matrix.bitcoind_version }})
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        bitcoind_version: ['30', '28']
+    steps:
+      - name: git checkout
+        uses: actions/checkout@v5
+
+      - name: Clean up runner space
+        uses: ./.github/actions/cleanup-space
+
+      - name: setup go ${{ env.GO_VERSION }}
+        uses: actions/setup-go@v5
+        with:
+          go-version: '${{ env.GO_VERSION }}'
+
+      - name: add go bin to PATH
+        run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+
+      - name: install btcd ${{ env.BTCD_VERSION_LATEST }}
+        run: go install -v github.com/btcsuite/btcd@${{ env.BTCD_VERSION_LATEST }}
+
+      - name: check btcd version
+        run: btcd --version
+
+      # For bitcoind backend tests, btcd remains the shared miner while the
+      # matrix covers both bitcoind v30 (latest) and v28 (older).
+      - name: extract bitcoind from docker image (${{ matrix.bitcoind_version }})
+        run: |-
+          IMAGE=${{ env.BITCOIND_IMAGE }}:${{ matrix.bitcoind_version }}
+          docker pull $IMAGE
+
+          BIN_PATH=$(docker run --rm --entrypoint sh $IMAGE -c '
+            command -v bitcoind ||
+            find /opt /usr -type f -name bitcoind 2>/dev/null | head -n 1
+          ')
+          if [ -z "$BIN_PATH" ]; then
+            echo "could not locate bitcoind in $IMAGE" >&2
+            exit 1
+          fi
+
+          CONTAINER_ID=$(docker create $IMAGE)
+          sudo docker cp $CONTAINER_ID:$BIN_PATH /usr/local/bin/bitcoind
+          docker rm $CONTAINER_ID
+          bitcoind --version
+
+      - name: run itest (bitcoind, kvdb)
+        run: make itest chain=bitcoind db=kvdb
+
+      - name: upload itest logs
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: itest-logs-bitcoind-${{ matrix.bitcoind_version }}
+          path: itest/test-logs
+          retention-days: 5
+
+  ########################
+  # Complete parallel coverage uploads
+  ########################
+  finish:
+    name: Finish coverage upload
+    if: ${{ !cancelled() }}
+    needs: [unit-test, itest-db]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Finish parallel Coveralls upload
+        uses: coverallsapp/github-action@v2
+        continue-on-error: true
+        with:
+          parallel-finished: true

.gitignore

@@ -2,7 +2,20 @@ btcwallet
 vendor
 .idea
 coverage.txt
+coverage-itest-postgres.txt
+coverage-itest-sqlite.txt
 *.swp
 .vscode
 .DS_Store
 .aider*
+/.worktrees/
+coverage.out
+*.prof
+*.test
+*cpu.out
+
+# Integration test logs.
+itest/test-logs/
+
+# Backwards compatibility for older log dir.
+itest/.minerlogs/