fix: skip grouped positionals satisfied by options#6374
Draft
Agentriel wants to merge 1 commit into
Draft
Conversation
Author
|
GitHub Actions is currently waiting for first-time contributor workflow approval on this PR. I ran the focused checks locally:
|
Member
|
Moving to a draft as our contrib guide asks for maintainer buy-in on a proposed solution before moving onto a PR. See also https://epage.github.io/dev/pr-style/#d-issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1794.
This changes positional parsing so a positional argument that belongs to a non-
multipleArgGroupis skipped when another member of that group has already been provided on the command line and there is a later positional that can receive the value.That lets
--option1 valuebindvalueto the next positional instead of first assigning it to the grouped positional and then failing validation with an argument conflict. If there is no later positional, parsing still leaves the value on the grouped positional so existing conflict diagnostics are preserved.Tested locally:
cargo fmt --checkcargo test --test builder issue_1794cargo test --test builder groups::cargo test --test builder positionals::cargo test -p clap_buildergit diff --check