Skip to content

Simplify spring-sleuth GitHub action#1976

Merged
jochenehret merged 1 commit into
developfrom
simplify_spring_sleuth_action
May 29, 2026
Merged

Simplify spring-sleuth GitHub action#1976
jochenehret merged 1 commit into
developfrom
simplify_spring_sleuth_action

Conversation

@jochenehret
Copy link
Copy Markdown
Contributor

What is this change about?

Simplify "spring-sleuth" GitHub action. Automatic commits of the rebuilt jar may lead to cyclic action triggers with undesired results. Instead, just test if "mvn package" is successful or not.

Please provide contextual information.

#1969

What version of cf-deployment have you run this cf-acceptance-test change against?

N/A

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

* automatic commit of rebuilt jar file may lead to cyclic triggers
* so just check if "mvn package" succeeds and tell user to manually create PR with updated jar
@jochenehret jochenehret requested a review from a team May 29, 2026 09:42
Copy link
Copy Markdown
Contributor

@hamideh-amini-khezrabad hamideh-amini-khezrabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochenehret jochenehret merged commit 1ab67d9 into develop May 29, 2026
4 checks passed
@jochenehret jochenehret deleted the simplify_spring_sleuth_action branch May 29, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants