chore: add refactoring skill for behavior-preserving code changes#147
Open
jamesmblair wants to merge 6 commits into
Open
chore: add refactoring skill for behavior-preserving code changes#147jamesmblair wants to merge 6 commits into
jamesmblair wants to merge 6 commits into
Conversation
Adds a refactoring skill that enforces behavior preservation during structural code changes. Includes process flowchart, yellow-light change guidance (type swaps, field migrations), safe refactorings reference, and red flags. Born from a real incident where cooldown enforcement was silently dropped during a model migration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ter process Add a Scope Discipline section naming the two failure modes (drift, "I notice this is messy" trap), broaden the description to cover "clean up," "reorganize," "extract," etc., remove the Mermaid flowchart in favor of prose, and label SEBT-specific examples as illustrative. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jamesmblair
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
refactoringskill and CLAUDE.md principle to enforce behavior preservation during structural code changes. Born from a real incident where cooldown enforcement was silently dropped during a model migration (cases vs applications refactor in DC-257).What's included
.claude/skills/refactoring/SKILL.md) — Process flowchart, yellow-light change guidance, red flagssafe-refactorings.md) — 14 mechanical transformations safe without test coverage, with "safe because" rationale and "watch for" caveatsKey concepts