DC-284 DRYing up appsettings#193
Draft
ShaynaCummings wants to merge 2 commits into
Draft
Conversation
ShaynaCummings
commented
Apr 21, 2026
jamesmblair
reviewed
Apr 21, 2026
jamesmblair
reviewed
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
| "DiSessionToken: fallback for when the frontend DI SDK is not integrated. Any value works in sandbox (e.g., 'sandbox-placeholder'). In production, the frontend sends a real token and this fallback is not used.", | ||
| "SandboxPhoneOverride: when set, overrides the user's phone number in Socure requests so DocV SMS links go to your real phone. Format: +1XXXXXXXXXX. Leave null or remove in production." | ||
| ], | ||
| "Socure": { |
Member
Author
There was a problem hiding this comment.
future - move enabled into feature flag
ShaynaCummings
commented
Apr 21, 2026
| @@ -94,10 +66,10 @@ | |||
| }, | |||
| "Smarty": { | |||
| "Enabled": false, | |||
Member
Author
There was a problem hiding this comment.
future - move this to feature flag
ShaynaCummings
commented
Apr 21, 2026
| "PermitLimit": 10, | ||
| "WindowMinutes": 1.0 | ||
| }, | ||
| "WebhookRateLimitSettings": { |
Member
Author
There was a problem hiding this comment.
leave this here
Member
Author
There was a problem hiding this comment.
in the future it would be dependent on socure feature flag
ShaynaCummings
commented
Apr 21, 2026
| "StateHouseholdId": { | ||
| "PreferredHouseholdIdTypes": ["Email"] | ||
| }, | ||
| "AppConfig": { |
Member
Author
There was a problem hiding this comment.
all of this is configured in tofu. can take out
ShaynaCummings
commented
Apr 21, 2026
| "Enabled": false, | ||
| "AuthId": "", | ||
| "AuthToken": "", | ||
| "AuthId": "SECRET_STORE_IN_USERSECRETS_OR_AWS_SECRETS_NOT_APP_CONFIG", |
Member
Author
There was a problem hiding this comment.
move authid and autoken here to appsettings.development
ShaynaCummings
commented
Apr 21, 2026
| "TimeoutSeconds": "20" | ||
| }, | ||
| "AddressValidationPolicy": { | ||
| "AllowGeneralDelivery": true |
Member
Author
There was a problem hiding this comment.
default to false.
Member
Author
There was a problem hiding this comment.
future: think about how we would group this under under subkeys : addressvalidtion -> policy -> SMARTY
ShaynaCummings
commented
Apr 21, 2026
| "StreetAbbreviations": {}, | ||
| "MaxStreetAddressLength": 0 | ||
| }, | ||
| "FeatureManagement": { |
Member
Author
There was a problem hiding this comment.
check w devika whether these are sensible defaults
Member
Author
There was a problem hiding this comment.
after we figure this out we should audit what's set in aws
Member
Author
There was a problem hiding this comment.
ultimately we need to document this
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
| "Audience": "SEBT.Portal.Web", | ||
| "ExpirationMinutes": 60 | ||
| }, | ||
| "PluginAssemblyPaths": ["plugins-dc", "plugins-co"], |
Member
Author
There was a problem hiding this comment.
double check whether it needs to have at least one
ShaynaCummings
commented
Apr 21, 2026
| "ClientSecret": "YOUR_CBMS_CLIENT_SECRET", | ||
| "ApiBaseUrl": "https://test-ch2-api.state.co.us/ext-uat-c-cbms-cfa-eapi/api", | ||
| "TokenEndpointUrl": "https://test-ch2-api.state.co.us/ext-uat-c-cbms-oauth-app/token", | ||
| "Return404ForGetAccountDetails": false |
Member
Author
There was a problem hiding this comment.
check whether this was removed
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
| "StateHouseholdId": { | ||
| "PreferredHouseholdIdTypes": ["Phone"] | ||
| }, | ||
| "DevelopmentPhoneOverride": { |
Member
Author
There was a problem hiding this comment.
originally for CO dev. might be able to remove
ShaynaCummings
commented
Apr 21, 2026
Comment on lines
25
to
26
| "DCConnector": { | ||
| "ConnectionString": "Server=localhost,1434;Database=DcSource;User Id=sa;Password=YOUR_PASSWORD;TrustServerCertificate=True;" |
ShaynaCummings
commented
Apr 21, 2026
| "ClientId": "YOUR_OIDC_STEP_UP_CLIENT_ID", | ||
| "RedirectUri": null | ||
| } | ||
| "Socure": { |
Member
Author
There was a problem hiding this comment.
check if it should only live in DC - nick to verify
ShaynaCummings
commented
Apr 21, 2026
| "EmailPattern": "sebt.dc+{0}@codeforamerica.org", | ||
| "State": "dc" | ||
| }, | ||
| "AddressValidationPolicy": { |
ShaynaCummings
commented
Apr 21, 2026
| "AuthId": "SECRET_STORE_IN_USERSECRETS_OR_AWS_SECRETS_NOT_APP_CONFIG", | ||
| "AuthToken": "SECRET_STORE_IN_USERSECRETS_OR_AWS_SECRETS_NOT_APP_CONFIG" | ||
| }, | ||
| "_socure_comment": [ |
Member
Author
There was a problem hiding this comment.
future - look into jsonc or figure out if comments are legal
ShaynaCummings
commented
Apr 21, 2026
| "CoLoadedStreamlineCases": "IAL1plus", | ||
| "NonCoLoadedStreamlineCases": "IAL1plus" | ||
| }, | ||
| "IdProofingRequirements": { |
Member
Author
There was a problem hiding this comment.
will be addressed by James's upcoming PR
ShaynaCummings
commented
Apr 21, 2026
| "IdProofingValidity": { | ||
| "ValidityDays": 1826 | ||
| }, | ||
| "DevelopmentPhoneOverride": { |
Member
Author
There was a problem hiding this comment.
we can probably remove
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
commented
Apr 21, 2026
ShaynaCummings
force-pushed
the
chore/dc-284
branch
from
920e1cf to
f7e06cc
Compare
ShaynaCummings
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
https://codeforamerica.atlassian.net/browse/DC-284
✍️ Description
Cleaning up and de-duping appsettings.json + example json files for Development, CO, DC envs to clear the way for auto diff checking of config changes
🔗 Links to related PRs
✅ Completion tasks