Add pre-approval email notice templates for DC SUN Bucks#262
Draft
jamesmblair wants to merge 14 commits into
Draft
Add pre-approval email notice templates for DC SUN Bucks#262jamesmblair wants to merge 14 commits into
jamesmblair wants to merge 14 commits into
Conversation
Mobile-first, email-client-safe HTML template for the DC SUN Bucks pre-approval notice sent to parents/guardians of eligible students. Includes DC branding, multi-language help links, USDA non-discrimination statement, and appeal rights sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds email-templates/verify.mjs — a zero-dependency Node.js script that lints HTML email templates for email-safe structure (18 checks across required structure, CSS safety, brand consistency, and content safety). Passes against PreApprovalNotice.html; exits non-zero on violations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ation workflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Restrict Bash permissions from broad wildcards (node:*, rm:*) to specific commands the skill actually needs (verify.mjs, _snapshots/). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Four of nine pre-approval email templates (ExistingCardEn, NewCardEs, NewCardAm, ExistingCardAm) shipped with corrupted inline base64 logo images — truncated, duplicated, or subtly miscoded. Visual review caught the broken renders; the existing 18 structural lint checks did not. - Replace the corrupted data URIs in those four templates with the canonical bytes from email-templates/assets/sun-bucks-logo-inline.html - Add verify.mjs check #19 (logo-base64-integrity) that compares any embedded data URI against the canonical asset and fails on mismatch - Update the email-template skill workflow with a placeholder + script substitution pattern, since pasting >10KB base64 blobs directly into Write produces silent corruption Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| function extractCssPropertyValues(source, property) { | ||
| // Escape hyphens in the property name for use in a regex. | ||
| const escapedProp = property.replace(/-/g, '\\-'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
email-templates/test-inputs/; HTML generated via pandoc + email-template skill matching the validatedPreApprovalNotice.htmlreference patternsemail-templates/assets/sun-bucks-logo-inline.htmlverify.mjsenforces 19 structural lint rules on every template (email-client safety, brand colors, table-only layout, base64 integrity)Test plan
node email-templates/verify.mjs(19/19 checks)🤖 Generated with Claude Code