DC-472(Bug): Show correct offboarding screen for co-loaded users#346
Open
noxmwalsh wants to merge 7 commits into
Open
DC-472(Bug): Show correct offboarding screen for co-loaded users#346noxmwalsh wants to merge 7 commits into
noxmwalsh wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
DC-472
Description
This PR resolves off-boarding reason from the warehouse household cohort as opposed to the session flag from before:
CoLoadedCohortClassifier(shared with dashboard household reads) to classify households asCoLoadedOnlyvs mixed/applicantSubmitIdProofingCommandHandler: on failure paths (SNAP/TANF mismatch, no ID, Socure failure, max attempts), looks up household by email and returnscoLoadedOnlywhen the cohort is co-loaded-onlyProcessWebhookCommandHandler: on DocV rejection, same cohort lookup; co-loaded-only users getcoLoadedOnlyinstead ofdocVerificationFailedreason=coLoadedOnlylike co-loaded session; analytics maps it tonot_foundco-loaded-pending-id-proofingpersona seeded withIsCoLoaded = falseso local testing matches productionNon-co-loaded / mixed households are unchanged: they still get
idProofingFailedordocVerificationFailedand the generic screens.Links to related PRs
None
Completion tasks
CoLoadedCohortClassifierTestsSubmitIdProofingCommandHandlerTests(SNAP mismatch + no-ID ->coLoadedOnly)ProcessWebhookCommandHandlerTests(DocV reject + co-loaded-only ->coLoadedOnly)off-boarding/page.test.tsx(reason=coLoadedOnlyshows co-loaded copy)DatabaseSeederTests(pending persona expectsIsCoLoaded = false)Test plan
/off-boarding?reason=coLoadedOnly, co-loaded headingsebt.dc+non-co-loaded@codeforamerica.org, DOB 10/09/1986 + wrong SNAP?reason=idProofingFailed, "We want to keep your account safe"?reason=docVerificationFailed, "We couldn't verify your identity"