DC-456 - spinner-only loading state for DC id-proofing; stop copy key leak#364
Open
necampanini wants to merge 3 commits into
Open
DC-456 - spinner-only loading state for DC id-proofing; stop copy key leak#364necampanini wants to merge 3 commits into
necampanini wants to merge 3 commits into
Conversation
noxmwalsh
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
DC-456
✍️ Description
DC users who submitted the id-proofing form briefly saw the literal text "title" and "body" inside a blue box while the request was in flight. The form used
LoadingInterstitialwith i18n keys from thestep-upProcessingnamespace, which is only populated for CO (DC's content sheet marks those rows!N/A!), so i18next fell back to the key names. The loading branch now gates on copy presence in the active locale bundle (i18n.exists('step-upProcessing:title') && i18n.exists('step-upProcessing:body')): when the keys exist the titledLoadingInterstitialrenders, when they don't the form falls back to a centered USWDS spinner inside arole="status"region. Adding the copy upstream is enough to switch in the titled interstitial for any state, no code change needed.🔗 Links to related PRs
✅ Completion tasks
Priority Review Table
IdProofingForm.tsxIdProofingForm.test.tsx