DC-477 - prevent double-submit on enrollment checker review page#365
Open
necampanini wants to merge 2 commits into
Open
DC-477 - prevent double-submit on enrollment checker review page#365necampanini wants to merge 2 commits into
necampanini wants to merge 2 commits into
Conversation
noxmwalsh
reviewed
May 29, 2026
| <button | ||
| type="button" | ||
| className="usa-link usa-button--unstyled" | ||
| onClick={() => { |
Contributor
There was a problem hiding this comment.
Does it make sense to disable this too along with the "Back" and "Submit" button. Maybe that's a product call, but I feel like it would make sense.
noxmwalsh
approved these changes
May 29, 2026
Contributor
noxmwalsh
left a comment
There was a problem hiding this comment.
Approved with comments regarding disabling additional buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
DC-477
✍️ Description
Prevents double submission on the enrollment checker review page. A fast double-click on Submit could fire the check twice: the
isSubmittingstate flag isn't updated until React's next render, so both click handlers ran against the stalefalsevalue and both passed the guard. A synchronoususeRefguard now rejects the second click immediately. The Submit button shows a loading state and the Back button is disabled while the request is in flight.🔗 Links to related PRs
✅ Completion tasks
Priority Review Table
src/SEBT.EnrollmentChecker.Web/src/app/review/page.tsxhandleSubmit()+submittingRefsrc/SEBT.EnrollmentChecker.Web/src/features/enrollment/components/ReviewPage.tsxisSubmittingprop wiringsrc/SEBT.EnrollmentChecker.Web/src/app/review/page.test.tsxsrc/SEBT.EnrollmentChecker.Web/src/features/enrollment/components/ReviewPage.test.tsx