Plone 6 + py3 only, Makefile, GH Actions by jensens · Pull Request #113 · collective/pas.plugins.ldap

jensens · 2022-02-09T15:05:12Z

No description provided.

find . -name "*.py" -exec pyupgrade --py3-only --py37-plus {} +

jensens · 2023-06-14T11:04:46Z

Test setup is broken: Testrunner and LDAP (slapd) not found.
@rnixx I think I need some hints how to configure it.

Otherwise datatypes.py is missing.

mauritsvanrees · 2023-11-27T22:16:44Z

I have done a few minor fixes on the p6 branch.

Two problems remain, as @jensens already mentioned: no tests found and slapd not found.

When you run make test, it executes .mxmake/files/run-tests.sh pas.plugins.ldap. This boils down to venv/bin/zope-testrunner --module=pas.plugins.ldap, and this finds zero tests. So the test runner does not find any tests. The pas.plugins.ldap package is installed though, in editable mode.

What works for me instead: venv/bin/zope-testrunner --path src. I don't know where to fix this though: I don't know how the run-tests.sh file is created.

If we fix that, the second problem is that slapd is not found:

$ venv/bin/zope-testrunner --path src 
Running pas.plugins.ldap.testing.PASLDAPLayer tests:
  Set up node.ext.ldap.testing.SlapdConf /tmp/tmp59y4prjm
SlapdConf set up.
in 0.000 seconds.
  Set up node.ext.ldap.testing.Slapd 
Starting LDAP server: 
slapd -f /tmp/tmp59y4prjm/slapd.conf -h ldap://127.0.0.1:12345 -d 0
Traceback (most recent call last):
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/venv/lib/python3.11/site-packages/zope/testrunner/runner.py", line 464, in run_layer
    setup_layer(options, layer, setup_layers)
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/venv/lib/python3.11/site-packages/zope/testrunner/runner.py", line 829, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/venv/lib/python3.11/site-packages/zope/testrunner/runner.py", line 829, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/venv/lib/python3.11/site-packages/zope/testrunner/runner.py", line 829, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/venv/lib/python3.11/site-packages/zope/testrunner/runner.py", line 834, in setup_layer
    layer.setUp()
  File "/var/zope/kennis6-9350/checkouts/pas.plugins.ldap/sources/node.ext.ldap/src/node/ext/ldap/testing/__init__.py", line 172, in setUp
    self.slapd = subprocess.Popen(cmd)
  File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'slapd'

I did run make install first, and this creates an slapd command in ./openldap/servers/slapd/. When I add this directory to the path and run the tests, slapd can start, but then we are missing ldapadd. This is in ./openldap/bin/. So I add this to the PATH as well, and... success!

$ venv/bin/zope-testrunner --path src
...
Total: 28 tests, 0 failures, 0 errors and 0 skipped in 1.948 seconds.

This is with Python 3.11 on Ubuntu 22.04.

@jensens @rnixx Does this give you enough hints to pick this up again?

mauritsvanrees · 2023-11-27T22:23:30Z

In other news, the p6 branch seems to work fine in practice for one client that we are testing it for, and where previous versions run fine on Plone 4.3 and 5.2.

Using these versions next to an internal release of p6:

bda.cache = 1.3.0
five.globalrequest = 99.1
node = 1.2.1
node.ext.ldap = 1.2
node.ext.ugm = 1.1
odict = 1.9.0
passlib = 1.7.4
pyasn1 = 0.5.1
pyasn1-modules = 0.3.0
python-ldap = 3.4.4
python-memcached = 1.59
yafowil = 3.1.0
yafowil.bootstrap = 2.0.0a1
yafowil.plone = 5.0.0a1
yafowil.widget.array = 2.0a1
yafowil.widget.dict = 2.0a1
yafowil.yaml = 2.0

I don't think we are using groups from LDAP in this site. But authentication works, and search works.

Control panel could be a bit better: fieldsets are not shown in tabs, but simply everything below each other. But that is a minor point for me.

…nk> should be removed, at line 7, column 66" message

…d load_zcml - Regenerate Makefile with `uvx mxmake update` (mxmake 2.2.0). New Makefile fixes the mxdev offline-mode error in CI: SOURCES_TARGET now runs online to populate `.mxdev_cache` before FILES_TARGET reads it offline. - Workflow: pass `PRIMARY_PYTHON=\${{ matrix.python }}` to make so the matrix Python is actually used. The previous `VENV=off` had no effect (the variable is `VENV_ENABLED`), so uv created the venv with system Python 3.12 regardless of the matrix value. - instance.yaml: replace deprecated `load_zcml: {package_includes: [...]}` with `zcml_package_includes: [...]` (cookiecutter-zope-instance >=2.0). - .gitignore: ignore generated `/.mxdev_cache/`.

`ldaptesting.props` (upstream node.ext.ldap LDAPProps) has no `roles` attribute, so reading it raised AttributeError. Inside the `_ldap_props` property getter this gets re-wrapped by Python as `AttributeError: _ldap_props`, which cascaded to the 25 test failures. Hardcode the test fixture to `["Member"]` (the same value as `DEFAULTS["server.roles"]`).

jensens · 2026-04-27T09:33:24Z

@macagua I fixed the branch - what is missing are some basic manual tests if everything is working fine in a real Plone site with user and groups and if the ZMI UI works.

macagua · 2026-04-27T09:40:51Z

@szakitibi Thanks to @jensens's work, this branch is now up to date with the main branch, we just need to way for the merge to main branch.

@jensens, is there something can I help you? in addition to testing your changes in the p6 branch

@macagua

Hi @jensens I would like to continue this job, Can you tell me what tasks are pending to help you to finish your work?

@jensens said here:

It needs a rebase of main (conflicts expected, mostly to take stuff from p6 branch I guess) and then it is ready for merge and a 2.0 release.

I think that is still relevant, p6 is 38 commit behind currently and can't automatically merge.

macagua · 2026-04-27T09:42:09Z

@macagua I fixed the branch - what is missing are some basic manual tests if everything is working fine in a real Plone site with user and groups and if the ZMI UI works.

@jensens Great to read this, let me try and test these stuff.

…ation #131

…'LDAP / Active Directory Configuration' Plone control panel #131 #113

macagua · 2026-05-02T18:25:23Z

@jensens, I added more improvements about UX for the Plone Control Panel, it looks like the following screenshot:

screenshot-localhost_8080-2026 05 02-20_19_20

I’ve split the entire form into four tabs, much like the Plone Classic UI.

I added full unit test support for this add-on

======================================================================================== 238 passed, 5 warnings in 4.03s ========================================================================================
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
src/pas/plugins/ldap/__init__.py                        16      0   100%
src/pas/plugins/ldap/cache.py                          111      0   100%
src/pas/plugins/ldap/defaults.py                         2      0   100%
src/pas/plugins/ldap/interfaces.py                       8      0   100%
src/pas/plugins/ldap/monkey.py                          63      0   100%
src/pas/plugins/ldap/plonecontrolpanel/__init__.py       9      0   100%
src/pas/plugins/ldap/plonecontrolpanel/cache.py         22      0   100%
src/pas/plugins/ldap/plugin.py                         357      0   100%
src/pas/plugins/ldap/properties.py                     285      0   100%
src/pas/plugins/ldap/setuphandlers.py                   29      0   100%
src/pas/plugins/ldap/sheet.py                           57      0   100%
------------------------------------------------------------------------
TOTAL                                                  959      0   100%

Also I updated the README file for the general documentation.

jensens · 2026-05-04T13:05:35Z

@macagua This is awesome! I merge it now, but I do not have time today for a release.

szakitibi · 2026-05-12T14:50:24Z

... I merge it now, but I do not have time today for a release.

According to https://pypi.org/project/pas.plugins.ldap/#history no release has been created since.

jensens mentioned this pull request Feb 14, 2022

Group search does not work correctly in Plone 5.2-python3 with Active Directory #100

Open

jensens added 12 commits June 14, 2023 10:41

basic refactoring for plone 6

e093533

automated pyupgrade

fa5cdb8

find . -name "*.py" -exec pyupgrade --py3-only --py37-plus {} +

updates for plone 6, also make file based install

a3ea9b1

use https clones

09a6c5d

install apt deps

92bf264

no local components

ab31dd8

optimize cache get by @ale-rt see #110

c9de37e

optimize cache #110

e38b1c7

fix check, due to chnage in underlying impl

4267158

set low default timeouts

6faaa24

document timeouts

c323a08

increase overall timeout to 30s

bca0534

jensens force-pushed the p6 branch from d7a161e to bca0534 Compare June 14, 2023 08:42

jensens added 7 commits June 14, 2023 10:44

fix python version test

b5de99d

update makefile et al

b5101f5

corrections

d567705

fix git urls

b99abff

fix test setup

a4a93b7

install zope.testrunner

b96bc81

add ldap

10169b4

mauritsvanrees added 3 commits November 27, 2023 22:26

yafowil.plone branch bootstrap-plone6 was merged to master.

36bb808

test-ignore-warnings does not exist, run 'make test' instead

be6d5f4

We need yafowil master instead of 3.0.

6e6c885

Otherwise datatypes.py is missing.

macagua added 3 commits June 21, 2025 12:00

Fixed the error "zope.tal.htmltalparser.EmptyTagError: Close tag </li…

44a61cd

…nk> should be removed, at line 7, column 66" message

Added the initial i18n support #131

3ee184d

Reorganize the use of the logging library

04efa94

jensens added 2 commits April 27, 2026 11:07

macagua added 17 commits April 29, 2026 23:24

Updated the README file

b37a8ec

Added the LICENSE.GPL file

585d7ec

Added more improvements about i18n support and updated Spanish transl…

2d52f0c

…ation #131

Added more improvements about QA validations

373d126

Updated the README file

6ab8beb

Updated the README file

7a4d056

Updated the README file

f3cd8dc

Updated the README file

eea9c74

Updated the README file

00b0df3

Added more improvements about i18n support #131

cafbfdd

Added the CONTRIBUTORS file

3956526

Updated the README file

55f3ba1

Updated the README file

592d7f5

Updated the README file

7d185d8

Added more improvments about the i18n support, also a new UX for the …

3488632

…'LDAP / Active Directory Configuration' Plone control panel #131 #113

Added full support for all unit test #113

1260b7e

Reusing the PACKAGE_NAME variable in the logger #113

c6850ad

macagua added 3 commits May 4, 2026 06:07

Updated the README file

1a9095b

Updated the README file

428d863

Updated the README file

622cfae

jensens merged commit a305ff0 into main May 4, 2026
7 checks passed

jensens deleted the p6 branch May 4, 2026 13:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Plone 6 + py3 only, Makefile, GH Actions#113

Plone 6 + py3 only, Makefile, GH Actions#113
jensens merged 78 commits into
mainfrom
p6

jensens commented Feb 9, 2022

Uh oh!

jensens commented Jun 14, 2023

Uh oh!

mauritsvanrees commented Nov 27, 2023

Uh oh!

mauritsvanrees commented Nov 27, 2023

Uh oh!

jensens commented Apr 27, 2026

Uh oh!

macagua commented Apr 27, 2026

Uh oh!

macagua commented Apr 27, 2026

Uh oh!

macagua commented May 2, 2026 •

edited

Loading

Uh oh!

jensens commented May 4, 2026

Uh oh!

Uh oh!

szakitibi commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jensens commented Feb 9, 2022

Uh oh!

jensens commented Jun 14, 2023

Uh oh!

mauritsvanrees commented Nov 27, 2023

Uh oh!

mauritsvanrees commented Nov 27, 2023

Uh oh!

jensens commented Apr 27, 2026

Uh oh!

macagua commented Apr 27, 2026

Uh oh!

macagua commented Apr 27, 2026

Uh oh!

macagua commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jensens commented May 4, 2026

Uh oh!

Uh oh!

szakitibi commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

macagua commented May 2, 2026 •

edited

Loading