Attribute keep line breaks#216
Closed
thet wants to merge 3 commits into
Closed
Conversation
|
Coverage is 96.824% — attribute-keep-line-breaks into master. No base build found for |
This allows for multi-line or otherwise manually strangely formatted class attributes.
thet
force-pushed
the
attribute-keep-line-breaks
branch
from
b7b5467 to
e8ea579
Compare
ale-rt
pushed a commit
that referenced
this pull request
May 31, 2026
This was caused by a BeautifulSoup configuration default that caused some attributes to be stored as a list of strings. The PR forces all attributes to be stored as string. Refs. #216
ale-rt
pushed a commit
that referenced
this pull request
May 31, 2026
This was caused by a BeautifulSoup configuration default that caused some attributes to be stored as a list of strings. The PR forces all attributes to be stored as string. Refs. #216
Member
|
The reason why this fails is because class is declared as a "multi-valued-attribute": I think the cleaner solution is to pass the proper argument to the parser, see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keep line breaks: Do not reformat class attribute values.
This allows for multi-line or otherwise manually strangely formatted
class attributes.
data-pat-* attributes are already kept.
This PR potentially replaces:
#213
#212
#211
But this does not allow for automatic multiline-formatting. So data-pat-* attributes values and class attributes are not split one-by-line. They just keep the formatting they already have.