Reapply "[APIE-1040] Add generic --wait framework; refactor Flink sta…#3389
Reapply "[APIE-1040] Add generic --wait framework; refactor Flink sta…#3389Steven Gagniere (sgagniere) wants to merge 1 commit into
Quality Gate passed
Annotations
Check failure on line 161 in test/test-server/flink_onprem_handler.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "test-pool" 4 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=b1b75913-4ded-4924-85a6-9cb978160573&open=b1b75913-4ded-4924-85a6-9cb978160573
Check warning on line 151 in pkg/wait/wait_test.go
sonarqube-confluent / SonarQube Code Analysis
Defer the cancel function 'cancel' after this context creation to prevent resource leaks.
[S8188] Context cancellation functions should be deferred
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=849b7299-b589-458c-a04e-4ce2b848f052&open=849b7299-b589-458c-a04e-4ce2b848f052
Check failure on line 1311 in test/test-server/flink_onprem_handler.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=86a553c3-b97a-4cdd-9c3a-09b1faf509de&open=86a553c3-b97a-4cdd-9c3a-09b1faf509de
Check warning on line 192 in pkg/wait/wait_test.go
sonarqube-confluent / SonarQube Code Analysis
Defer the cancel function 'cancel' after this context creation to prevent resource leaks.
[S8188] Context cancellation functions should be deferred
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=a4783fce-4caf-482f-bcbd-1f358150cf5a&open=a4783fce-4caf-482f-bcbd-1f358150cf5a
Check failure on line 386 in test/test-server/flink_onprem_handler.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "SELECT * FROM test_table" 3 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=b035b92b-6182-4663-ab9c-189f660fef99&open=b035b92b-6182-4663-ab9c-189f660fef99
Check failure on line 72 in internal/flink/command_statement_create.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 36 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=d0c95dde-e2cd-4f98-8433-8f4e97ccfb21&open=d0c95dde-e2cd-4f98-8433-8f4e97ccfb21
Check failure on line 148 in test/test-server/flink_gateway_router.go
sonarqube-confluent / SonarQube Code Analysis
Define a constant instead of duplicating this literal "SQL statement is completed" 3 times.
[S1192] String literals should not be duplicated
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=c51ee492-a812-4dc9-896b-c2583af138f9&open=c51ee492-a812-4dc9-896b-c2583af138f9
Check failure on line 51 in internal/flink/command_statement_create_onprem.go
sonarqube-confluent / SonarQube Code Analysis
Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed.
[S3776] Cognitive Complexity of functions should not be too high
See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3389&issues=063534a4-a8fd-42ec-bb31-3e7f3116e3f2&open=063534a4-a8fd-42ec-bb31-3e7f3116e3f2