esp: TempMount ESP if not already mounted#1126
Open
Johan-Liebert1 wants to merge 1 commit into
Open
Conversation
In the composefs Grub case we have `/sysroot/boot` and config related to Grub is stored in the directory. We were masking `/sysroot/boot` with an ESP mount which caused bootupd to write incorrect UUID (the ESP's) in `bootuuid.cfg` file rendering the system unbootable. Fix this by mounting the ESP at a temp location if we don't find it already mounted at predetermined locations Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
cgwalters
approved these changes
Jul 22, 2026
cgwalters
left a comment
cgwalters
left a comment
Member
There was a problem hiding this comment.
OK, makes sense to me.
However, one clear thing here is we should still probably push for adding /efi into our base images, because then this stuff becomes clearer.
Also that said: can't we just open the mount as a fd using the new mount api? I'm not aware of a strong reason for us to attach it to the namespace at all - and that would entirely avoid these bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the composefs Grub case we have
/sysroot/bootand config related to Grub is stored in the directory. We were masking/sysroot/bootwith an ESP mount which caused bootupd to write incorrect UUID (the ESP's) inbootuuid.cfgfile rendering the system unbootable.Fix this by mounting the ESP at a temp location if we don't find it already mounted at predetermined locations