Skip to content

Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432

Open
simplefarmer69 wants to merge 2 commits into
cowprotocol:mainfrom
simplefarmer69:add-k9-pupcup-mainnet
Open

Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432
simplefarmer69 wants to merge 2 commits into
cowprotocol:mainfrom
simplefarmer69:add-k9-pupcup-mainnet

Conversation

@simplefarmer69
Copy link
Copy Markdown

@simplefarmer69 simplefarmer69 commented May 19, 2026

Token Addition Request

Adding K9 and PUPCUP (World Pup Coin) — two ERC-20 tokens from the Clutch Puppies DeFi ecosystem on Ethereum mainnet.

K9

  • Name: K9
  • Symbol: K9
  • Contract:
  • Decimals: 18
  • Chain: Ethereum Mainnet (1)

PUPCUP (World Pup Coin)

  • Name: PUPCUP
  • Symbol: PUPCUP
  • Contract:
  • Decimals: 18
  • Chain: Ethereum Mainnet (1)

Both tokens are verified on Etherscan, scored 100/100 on TokenSniffer, and already listed on TrustWallet assets.

Summary by CodeRabbit

  • Chores
    • Updated the Ethereum mainnet token list: added K9 and PUPCUP with full metadata (contract addresses, symbols, names, 18 decimals, and logo URIs). These tokens are now available on the platform.
    • Bumped token-list patch version and refreshed its timestamp.

Review Change Stack

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b77aa88-9477-42ac-8872-b67ac61f3765

📥 Commits

Reviewing files that changed from the base of the PR and between e1758a5 and 058f134.

📒 Files selected for processing (1)
  • src/public/CowSwap.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/public/CowSwap.json

📝 Walkthrough

Walkthrough

This PR updates token-list metadata (timestamp and patch) and adds two Ethereum mainnet tokens—K9 and PUPCUP—to src/public/CowSwap.json, each with address, symbol, name, 18 decimals, and TrustWallet logoURI.

Changes

Token List Addition

Layer / File(s) Summary
Metadata bump
src/public/CowSwap.json
Updated timestamp and incremented version.patch in the token-list metadata.
Add K9 and PUPCUP tokens
src/public/CowSwap.json
Inserted two new tokens objects into the mainnet (chainId: 1) array with contract addresses, symbol, name, decimals: 18, and TrustWallet logoURI.

Possibly related issues

  • #1430: Requests addition of K9 token to mainnet with matching contract address, decimals, and logo data.
  • #1431: Requests addition of PUPCUP token to mainnet with matching contract address and image URI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny hop, two tokens come by,
K9 wags and PUPCUP waves hi,
Stamped with a time, version raised with cheer,
Mainnet bound — new entries appear! 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding two tokens (K9 and PUPCUP) to the CowSwap mainnet token list, which matches the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/public/CowSwap.json (1)

2167-2182: ⚡ Quick win

Keep chainId: 1 tokens in the mainnet section for consistency.

These two Ethereum mainnet entries are appended after the chainId: 59144 block. Please place them with the existing chainId: 1 tokens (ideally preserving the file’s ordering convention) to avoid structural drift.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/public/CowSwap.json` around lines 2167 - 2182, Move the two token objects
for K9 (address 0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId
59144 and insert them into the existing chainId: 1 (mainnet) token list so they
reside with other mainnet entries, preserving the file's ordering convention
(alphabetical or existing insertion pattern) and ensuring commas/JSON structure
remain valid after relocation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: You added two tokens (addresses
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930 and
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) but did not update the token-list
metadata; open src/public/CowSwap.json and update the top-level "timestamp" to
the current ISO date/time and increment the patch version in "version" (e.g.,
7.4.0 → 7.4.1) so consumers and caches detect the change; ensure the "timestamp"
and "version" fields are consistent with this addition.

---

Nitpick comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: Move the two token objects for K9 (address
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId
59144 and insert them into the existing chainId: 1 (mainnet) token list so they
reside with other mainnet entries, preserving the file's ordering convention
(alphabetical or existing insertion pattern) and ensuring commas/JSON structure
remain valid after relocation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b3b1a5bd-ebd5-4f03-94f7-c0b437a29715

📥 Commits

Reviewing files that changed from the base of the PR and between 5899637 and e1758a5.

📒 Files selected for processing (1)
  • src/public/CowSwap.json

Comment thread src/public/CowSwap.json Outdated
@simplefarmer69
Copy link
Copy Markdown
Author

Thanks for the review! Fixed in the latest commit: K9 and PUPCUP tokens are now sorted with the other chainId: 1 entries, and the list timestamp + patch version have been bumped accordingly.

@simplefarmer69
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant