Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432
Add K9 and PUPCUP (World Pup Coin) to CowSwap mainnet token list#1432simplefarmer69 wants to merge 2 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates token-list metadata (timestamp and patch) and adds two Ethereum mainnet tokens—K9 and PUPCUP—to ChangesToken List Addition
Possibly related issues
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/public/CowSwap.json (1)
2167-2182: ⚡ Quick winKeep
chainId: 1tokens in the mainnet section for consistency.These two Ethereum mainnet entries are appended after the
chainId: 59144block. Please place them with the existingchainId: 1tokens (ideally preserving the file’s ordering convention) to avoid structural drift.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/public/CowSwap.json` around lines 2167 - 2182, Move the two token objects for K9 (address 0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address 0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId 59144 and insert them into the existing chainId: 1 (mainnet) token list so they reside with other mainnet entries, preserving the file's ordering convention (alphabetical or existing insertion pattern) and ensuring commas/JSON structure remain valid after relocation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: You added two tokens (addresses
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930 and
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) but did not update the token-list
metadata; open src/public/CowSwap.json and update the top-level "timestamp" to
the current ISO date/time and increment the patch version in "version" (e.g.,
7.4.0 → 7.4.1) so consumers and caches detect the change; ensure the "timestamp"
and "version" fields are consistent with this addition.
---
Nitpick comments:
In `@src/public/CowSwap.json`:
- Around line 2167-2182: Move the two token objects for K9 (address
0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930) and PUPCUP (address
0x884649f1fE3Bf3Ae0Bd720Eaf660cB561dcE39ef) out of the section following chainId
59144 and insert them into the existing chainId: 1 (mainnet) token list so they
reside with other mainnet entries, preserving the file's ordering convention
(alphabetical or existing insertion pattern) and ensuring commas/JSON structure
remain valid after relocation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Thanks for the review! Fixed in the latest commit: K9 and PUPCUP tokens are now sorted with the other |
|
I have read the CLA Document and I hereby sign the CLA |
Token Addition Request
Adding K9 and PUPCUP (World Pup Coin) — two ERC-20 tokens from the Clutch Puppies DeFi ecosystem on Ethereum mainnet.
K9
PUPCUP (World Pup Coin)
Both tokens are verified on Etherscan, scored 100/100 on TokenSniffer, and already listed on TrustWallet assets.
Summary by CodeRabbit