Handle -fpic thunks#110
Open
Kenzzer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #90
On linux, the x86 binaries compiled with gcc's -fPIC option will often have a function prologue like this
This is unfortunate, because
call __x86_get_pc_thunk_digets moved into the trampoline. For any other kind of function this would be fine, but here it isn't because here's what__x86_get_pc_thunkdoes :The
regis the one that corresponds to the function name. EAX for AX, ECX for CX, etc...Now the return address in
espis that of the trampoline not the original function, so when jumping back to the original function the register contains an invalid value..This is what this PR fixes. If a call to
__x86_get_pc_thunkis identified as being moved into the trampoline, instead of copying the original bytes, we copy the opcodes formov reg, 0xSomeValuewhereregis the register that would have been assigned by__x86_get_pc_thunkand0xSomeValueis the value the register would have had in the original non-detour'd function.