refactor: replace formatBytes with humanize.IBytes - #2
Merged
Conversation
⬇️ Go test coverage decreased from 27.1% to 26.5% compared to a683de1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatBytesfunction withhumanize.IBytes()fromdustin/go-humanize, which was already an indirect dependencyTestFormatBytes(now testing library code)Details
The 12-line
formatBytesincmd/root.goreimplementedhumanize.IBytes()identically. Sincego-humanizewas already in the dependency graph (pulled in bytruenas-go), this is a pure code reduction with no new dependencies — just promotes it from indirect to direct.Test plan
go buildcompilesgo test ./...all passgo vet ./...clean