Skip to content

#1750: implemented GoUrlUpdater#1753

Merged
hohwille merged 7 commits into
devonfw:mainfrom
MarvMa:feature/#1750-gourlupdater
Mar 17, 2026
Merged

#1750: implemented GoUrlUpdater#1753
hohwille merged 7 commits into
devonfw:mainfrom
MarvMa:feature/#1750-gourlupdater

Conversation

@MarvMa

@MarvMa MarvMa commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #1750

Implemented changes:

  • added implementation for GoUrlUpdater to include GoLang in IDEasy

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls

coveralls commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 23195129905

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 70.621%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/url/UpdateInitiator.java 10 0.0%
com/devonfw/tools/ide/url/updater/UpdateManager.java 13 0.0%
com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java 32 84.73%
Totals Coverage Status
Change from base Build 23195120319: 0.01%
Covered Lines: 10768
Relevant Lines: 14648

💛 - Coveralls

@MarvMa MarvMa added the enhancement New feature or request label Mar 16, 2026
@MarvMa MarvMa self-assigned this Mar 16, 2026
@MarvMa
MarvMa requested a review from Copilot March 16, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Go language support to the URL-updater module by introducing a dedicated GoUrlUpdater, registering it in the update orchestration, and adjusting version filtering to exclude rc-style tags.

Changes:

  • Added GoUrlUpdater to fetch Go versions from GitHub tags and generate download URLs from go.dev/dl.
  • Registered GoUrlUpdater in UpdateManager so it runs as part of the full update process.
  • Updated global version filtering to treat rc versions as unstable and skip them.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java Registers the new GoUrlUpdater in the list of executed updaters.
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java Extends version filtering to drop rc versions.
url-updater/src/main/java/com/devonfw/tools/ide/url/tool/go/GoUrlUpdater.java Implements Go version discovery and download URL generation.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java Outdated
@hohwille hohwille changed the title Feature/#1750 implemented gourlupdater #1750: implemented GoUrlUpdater Mar 17, 2026
@hohwille hohwille added the go golang programming language support label Mar 17, 2026
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Mar 17, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for your PR. Your approach looks good to me. Great job. 👍
There are no official releases on GitHub for go so using the tag updater is the best choice.
Please note that go should not be part of the version identifier. I added according review suggestions that you can apply and adjust easily.
Also address the suggestions from Copilot that both seem reasonable.

When you are done, please run the updater locally and either create a PR for ide-urls or a directory listing as Ascii that you can attach to this PR as comment. Then we can see upfront if all is working as expected before we finally merge.

Comment thread url-updater/src/main/java/com/devonfw/tools/ide/url/tool/go/GoUrlUpdater.java Outdated
Comment thread url-updater/src/main/java/com/devonfw/tools/ide/url/tool/go/GoUrlUpdater.java Outdated
Comment thread url-updater/src/main/java/com/devonfw/tools/ide/url/tool/go/GoUrlUpdater.java Outdated
@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board Mar 17, 2026
@MarvMa

MarvMa commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

The requested changes have been implemented including the removal of go from the version identifier, a generalized method to remove version based on a optional string. That was necessary to filter out the release candidate versions based on a "contains" check. And a Test was integrated to ensure that the implementation works as expected.

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa Thanks for your updates. Everything perfect now including tests. Great work 👍
Ready for merge.

@hohwille
hohwille merged commit 66ce91d into devonfw:main Mar 17, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Mar 17, 2026
@hohwille hohwille added this to the release:2026.04.001 milestone Mar 17, 2026
@hohwille hohwille added the internal Nothing to be added to CHANGELOG, only internal story label Mar 17, 2026
MarvMa added a commit to MarvMa/IDEasy that referenced this pull request Apr 17, 2026
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
MarvMa added a commit to MarvMa/IDEasy that referenced this pull request Apr 17, 2026
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go golang programming language support internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create GoUrlUpdater

4 participants