#1750: implemented GoUrlUpdater#1753
Conversation
Pull Request Test Coverage Report for Build 23195129905Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Adds Go language support to the URL-updater module by introducing a dedicated GoUrlUpdater, registering it in the update orchestration, and adjusting version filtering to exclude rc-style tags.
Changes:
- Added
GoUrlUpdaterto fetch Go versions from GitHub tags and generate download URLs fromgo.dev/dl. - Registered
GoUrlUpdaterinUpdateManagerso it runs as part of the full update process. - Updated global version filtering to treat
rcversions as unstable and skip them.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java |
Registers the new GoUrlUpdater in the list of executed updaters. |
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java |
Extends version filtering to drop rc versions. |
url-updater/src/main/java/com/devonfw/tools/ide/url/tool/go/GoUrlUpdater.java |
Implements Go version discovery and download URL generation. |
You can also share your feedback on Copilot code review. Take the survey.
hohwille
left a comment
There was a problem hiding this comment.
@MarvMa thanks for your PR. Your approach looks good to me. Great job. 👍
There are no official releases on GitHub for go so using the tag updater is the best choice.
Please note that go should not be part of the version identifier. I added according review suggestions that you can apply and adjust easily.
Also address the suggestions from Copilot that both seem reasonable.
When you are done, please run the updater locally and either create a PR for ide-urls or a directory listing as Ascii that you can attach to this PR as comment. Then we can see upfront if all is working as expected before we finally merge.
|
The requested changes have been implemented including the removal of go from the version identifier, a generalized method to remove version based on a optional string. That was necessary to filter out the release candidate versions based on a "contains" check. And a Test was integrated to ensure that the implementation works as expected. |
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
This PR fixes #1750
Implemented changes:
GoUrlUpdaterto include GoLang in IDEasyChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal