ad-hoc sign macOS native binary in release build#2063
Open
shodiBoy1 wants to merge 2 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 28375511141Coverage increased (+0.004%) to 71.36%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
Contributor
|
I wanted to test this today, but I forgot my mac at home... will do this either tonight or on Friday... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #451
Implemented changes:
Testing instructions
This only touches the macOS build jobs , so a local mvn build won't exercise it. Two ways to verify:
Verify now (any Mac, most visible on Intel):
Verify after merge:
Download the next nightly mac build and run codesign -dv bin/ideasy → it should report Signature=adhoc, and ./bin/ideasy --version runs from
a fresh download.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal