#1676 import extra sdks automatically into ide #2073
Draft
vivu001 wants to merge 13 commits into
Draft
Conversation
- Load extra SDKs from ide-extra-tools.json and register supported ones in IntelliJ. - The IntelliJ merge template is expected from the settings repository.
…utomatically-into-IDE-' into feature/1676-Import-extra-SDKs-automatically-into-IDE-
…atically-into-IDE-
Collaborator
Coverage Report for CI Build 28498115208Coverage increased (+0.08%) to 71.442%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions27 previously-covered lines in 4 files lost coverage.
Coverage Stats💛 - Coveralls |
…med attribute placeholders in jdk-extra-java.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1676
Implemented changes:
$IDE_HOME/settings/ide-extra-tools.json.jdk-extra-java.xmlas the template for importing extra Java SDKs into IntelliJ. (Related PR #1676: import extra sdks automatically into ide ide-settings#88)jdk-extra-java.xml.ide updateso one update is enough.Testing instructions
Preconditions
Make sure the following files are available under
$IDE_HOME/settingsfor testing:ide-extra-tools.json/intellij/workspace/repository/.idea/jdk-extra-java.xmlManual test
ide update.$IDE_HOME/workspaces/main/.intellij/config/options/jdk.table.xmlAutomated test
Run the IntelliJ-related tests, especially the update flow test coverage:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal