Store GitHub token in native keyring#229
Open
albbas wants to merge 8 commits into
Open
Conversation
Member
Author
|
I see that the build fails, but not why. I get "page not found" when pressing the buildkite link. On my local Mac there are no warnings from |
Switches the Linux keyring backend from linux-native-sync-persistent (dbus/libdbus) to linux-native-async-persistent (zbus, pure Rust D-Bus). zbus has no libdbus dependency, unblocking fully static musl builds on Alpine without needing a from-source static dbus build in CI. The async backend's blocking shim deadlocks when called from the main thread, so all three keyring call sites are now wrapped in spawned threads. async-io is used as the executor to avoid conflicts with reqwest's background tokio runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user.tomlusernamein config file and read token from keyring at runtimeuser.tomlfiles containingtokenGITHUB_TOKENenvironment variable when keyring entry is unavailableImplementation
keyringdependency with platform-native backendsgut initNotes