Skip to content

Use <inheritdoc /> for TaskEnvironment in ResolveCodeAnalysisRuleSet - #14589

Merged
jankratochvilcz merged 1 commit into
mainfrom
jankratochvilcz-super-guide
Jul 31, 2026
Merged

Use <inheritdoc /> for TaskEnvironment in ResolveCodeAnalysisRuleSet#14589
jankratochvilcz merged 1 commit into
mainfrom
jankratochvilcz-super-guide

Conversation

@jankratochvilcz

Copy link
Copy Markdown
Contributor

Follow-up to #13636 addressing @OvesN's review nit.

Replaces the hand-written <summary> on the TaskEnvironment property with <inheritdoc />, matching the convention used by every other task migrated to multithreaded execution (Copy, Delete, Unzip, ResolveAssemblyReference, etc.).

Doc-comment only — no behavior change.

Follow-up to PR #13636 addressing review nit: align the TaskEnvironment
property doc comment with the convention used by all other migrated tasks.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 31, 2026 09:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates XML documentation for ResolveCodeAnalysisRuleSet.TaskEnvironment to use <inheritdoc />, aligning the task with the existing documentation convention used by other IMultiThreadableTask-migrated tasks. This is a doc-comment-only change with no behavioral impact.

Changes:

  • Replaced the hand-written <summary> on TaskEnvironment with <inheritdoc />.

@jankratochvilcz
jankratochvilcz requested a review from OvesN July 31, 2026 09:11
@jankratochvilcz
jankratochvilcz enabled auto-merge (squash) July 31, 2026 09:11

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — PR #14589

✅ 24/24 dimensions clean — no findings.

This PR replaces an explicit <summary> doc comment with /// <inheritdoc /> on the TaskEnvironment property in ResolveCodeAnalysisRuleSet. This is a purely cosmetic/documentation change with no behavioral impact. All 24 review dimensions are unaffected.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #14589 · sonnet46 · 22.2 AIC · ⌖ 5 AIC · ⊞ 4.9K

@jankratochvilcz
jankratochvilcz merged commit 29842cc into main Jul 31, 2026
20 checks passed
@jankratochvilcz
jankratochvilcz deleted the jankratochvilcz-super-guide branch July 31, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants