feat: Add onClose functionality to escape key event listener#570
Open
vkraucunas wants to merge 1 commit into
Open
feat: Add onClose functionality to escape key event listener#570vkraucunas wants to merge 1 commit into
vkraucunas wants to merge 1 commit into
Conversation
✅ Deploy Preview for ddgdash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
NPM npm i github:duckduckgo/privacy-dashboard#f53c06ba59327bb5c3d7e76b09780282e5c2d2caGit submodule: git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227Swift .package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "f53c06ba59327bb5c3d7e76b09780282e5c2d2ca"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
When a recent bug was discovered on Windows that prevented user from seeing the Done button and closing the dashboard, it was decided that adding an event listener for the escape key would be useful.
Steps to test this PR: