-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add deep copy functionality to Instance and related runtime cla… #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chirino
wants to merge
2
commits into
dylibso:main
Choose a base branch
from
chirino:instance-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
runtime/src/main/java/com/dylibso/chicory/runtime/internal/ExperimentalCopier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| package com.dylibso.chicory.runtime.internal; | ||
|
|
||
| import com.dylibso.chicory.runtime.ExecutionListener; | ||
| import com.dylibso.chicory.runtime.ImportValues; | ||
| import com.dylibso.chicory.runtime.Instance; | ||
|
|
||
| /** | ||
| * This class is experimental and may change in future releases. | ||
| * It provides a way to copy an Instance with options for execution listeners and import values. | ||
| * Copying an Instance is dangerous and should be done with caution. Potential issues include: | ||
| * <ul> | ||
| * <li>Linking breaks.</li> | ||
| * <li>Stateful host functions break: therefore it also breaks WASI. | ||
| * </ul> | ||
| */ | ||
| public final class ExperimentalCopier { | ||
|
|
||
| private ExperimentalCopier() { | ||
| // Prevent instantiation | ||
| } | ||
|
|
||
| /** | ||
| * Options for copying Instances. | ||
| * This class allows setting an execution listener and import values for the copy operation. | ||
| */ | ||
| public static class Options { | ||
| private ExecutionListener listener; | ||
| private ImportValues imports; | ||
|
|
||
| /** | ||
| * Set this if you want to replace the execution listener set on the original Instance. | ||
| */ | ||
| public Options withListener(ExecutionListener listener) { | ||
| this.listener = listener; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Set this if you want to replace the imports used on the original Instance. | ||
| * | ||
| * @param imports The import values to use when copying the Instance. | ||
| * @return This Options instance for method chaining. | ||
| */ | ||
| public Options withImports(ImportValues imports) { | ||
| this.imports = imports; | ||
| return this; | ||
| } | ||
|
|
||
| public ExecutionListener listener() { | ||
| return listener; | ||
| } | ||
|
|
||
| public ImportValues imports() { | ||
| return imports; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Creates a new Options instance for copying Instances. | ||
| * | ||
| * @return A new Options instance with default settings. | ||
| */ | ||
| public static Options options() { | ||
| return new Options(); | ||
| } | ||
|
|
||
| /** | ||
| * Copies an Instance with default options. | ||
| * | ||
| * @param original The original Instance to copy. | ||
| * @return A new Instance that is a copy of the original. | ||
| */ | ||
| public static Instance copy(Instance original) { | ||
| return copy(original, options()); | ||
| } | ||
|
|
||
| /** | ||
| * Copies an Instance with the specified options. | ||
| * | ||
| * @param original The original Instance to copy. | ||
| * @param options The options for copying, including execution listener and import values. | ||
| * @return A new Instance that is a copy of the original. | ||
| */ | ||
| public static Instance copy(Instance original, Options options) { | ||
| // We have to subclass Instance to access this protected constructor | ||
| return new Instance(original, options) {}; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need of resetting/recomputing fields shows that this is a leaky abstraction.