ci: fix bare-metal maintenance - #2199
Merged
Merged
Conversation
sespiros
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2194 introduced a subtle bug: the idea was to first apply the sync server, then patch it, then restart it. The problem with this approach is that the sync server is a
StatefulSet. The update semantics for these prevent rollouts when there are failing pods: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#forced-rollback. This means that the patch won't be rolled out if the unpatched pod failed. Since the reason for the patch was to prevent wrong scheduling and pod failures to begin with, this approach is not safe. Instead, we switch to a kustomization in-tree that applies the nodeSelector.Another issue that became apparent is that we're first deploying the sync server, and only then the hostpath driver. However, if the hostpath driver is currently broken or absent, the sync server won't become ready, waiting for a volume. This is addressed by reordering the resources.