treewide: preliminary b300 support by msanft · Pull Request #2566 · edgelesssys/contrast

msanft · 2026-08-04T07:37:27Z

In anticipation of Privatemode's B300 use, we can already prepare some (but not all) places in Contrast for B300 GPU support. For now, this PR uses the GB110_B300_SXM6_AC device ID from this table and the name normalization logic in the sandbox-device-plugin.
Closes CON-290

linear-code · 2026-08-04T07:37:42Z

CON-290

thomasten · 2026-08-04T09:18:16Z

+	"nvidia.com/GB110_B300_SXM6_AC",
+	"nvidia.com/GH100_H100_PCIE",
+	// TODO(msanft): remove when the GPU operator is updated in all clusters.
+	"nvidia.com/pgpu",


I don't remember what the reason was in Contrast to use pgpu instead of specific names. The user docs also recommend this. Was that related to the gpu-operator and will this change with the new version?

Was that related to the gpu-operator and will this change with the new version?

Exactly. Hence the comment

I vaguely remember some hacky patch inside Contrast to make specific names work esp. for Privatemode, which code path we didn't want to be taken for the general audience. But I might remember that wrong.

I think we (i.e. @charludo, iirc) removed that in Kata at some point when we didn't need it anymore?

I'm not sure exactly what patch you mean, do you remember when it was dropped?

In any case, iiuc, specific names should work: https://github.com/edgelesssys/contrast/blob/main/packages/by-name/kata/source/0018-shim-guess-CDI-devices-without-direct-match.patch

#2180 says that that patch "is brittle and should not be relied upon". I don't know why this is or whether this has changed.

charludo

Thanks for your efforts! This generally reads good to me, I have a couple nits in the comments + the below:

there's a leftover comment in genpolicy/package.nix:58 that should probably also go in the "fix outdated comments" commit.

charludo

Thanks for the changes! LGTM, also since nothing existing seems to break.

github-actions · 2026-08-17T11:07:23Z

Do the documentation changes need to be backported?

Changes to /docs/docs won't be visible until the next release.
If you are fixing something in the docs that should be immediately visible, the changes needs to be made to both /docs/docs and /docs/versioned_docs/version-X.Y, where X.Y is the version of the latest minor release.
This can be done in this same PR.

Yes, this should be backported to the current version of the docs.
No, the PR only contains docs changes relevant for future versions.

github-actions · 2026-08-17T11:09:08Z

PR Preview Action v1.8.1
🚀 View preview at https://edgelesssys.github.io/contrast/pr-preview/pr-2566/
Built to branch `gh-pages` at 2026-08-19 09:17 UTC. Preview will be ready when the GitHub Pages deployment is complete.

thomasten · 2026-08-17T20:42:10Z

  --set sandboxDevicePlugin.version=8e76fe81 \
  --set 'sandboxDevicePlugin.env[0].name=P_GPU_ALIAS' \
-  --set 'sandboxDevicePlugin.env[0].value=pgpu' \
+  --set 'sandboxDevicePlugin.env[0].value=' \


I think setting this to empty is wrong for this version of the gpu-operator

thomasten · 2026-08-17T20:43:39Z

This script now mixes stuff for the old gpu-operator and the new gpu-operator. The result will probably not work for either.

thomasten · 2026-08-17T20:49:07Z

+
+# TODO: Remove this workaround once the sandbox device plugin includes PCI ID 0x3182.
+# https://github.com/NVIDIA/gpu-operator/pull/2625
+patch_b300_pci_ids() {


The patch seems overly complicated. Can't we just put an up-to-date pci.ids in a ConfigMap and mount that into the main container to override the file?

Yes. I haven't got to review the patch yet, but I've verified it works for the new version of the operator.

msanft requested review from charludo and thomasten August 4, 2026 07:37

msanft added the no changelog PRs not listed in the release notes label Aug 4, 2026

msanft force-pushed the msanft/treewide/b300 branch from d6453e5 to aa3bec1 Compare August 4, 2026 07:46

thomasten reviewed Aug 4, 2026

View reviewed changes

charludo reviewed Aug 4, 2026

View reviewed changes

Comment thread justfile

Comment thread e2e/gpu/gpu_test.go

Comment thread e2e/gpu/gpu_test.go Outdated

Comment thread e2e/gpu/gpu_test.go Outdated

msanft force-pushed the msanft/treewide/b300 branch from aa3bec1 to a49b754 Compare August 4, 2026 11:33

msanft requested review from charludo and thomasten August 4, 2026 15:20

charludo approved these changes Aug 5, 2026

View reviewed changes

charludo mentioned this pull request Aug 17, 2026

dev-docs: update NVIDIA RIM IDs #2578

Open

msanft force-pushed the msanft/treewide/b300 branch from d977ddc to bda5598 Compare August 17, 2026 11:06

thomasten reviewed Aug 17, 2026

View reviewed changes

msanft force-pushed the msanft/treewide/b300 branch from bda5598 to 5f2c877 Compare August 18, 2026 07:44

msanft commented Aug 18, 2026

View reviewed changes

Comment thread dev-docs/nvidia/cdi.md Outdated

Comment thread docs/docs/howto/cluster-setup/bare-metal.md Outdated

Comment thread packages/by-name/scripts/upgrade-gpu-operator/upgrade-gpu-operator_test.sh Outdated

msanft commented Aug 18, 2026

View reviewed changes

Comment thread internal/kuberesource/parts.go Outdated

msanft force-pushed the msanft/treewide/b300 branch 2 times, most recently from d40eeba to f9b48d6 Compare August 18, 2026 08:45

msanft commented Aug 18, 2026

View reviewed changes

Comment thread docs/docs/howto/cluster-setup/bare-metal.md Outdated

msanft commented Aug 18, 2026

View reviewed changes

Comment thread internal/kuberesource/parts_test.go Outdated

msanft force-pushed the msanft/treewide/b300 branch 2 times, most recently from 8b09038 to 4cdbfcb Compare August 18, 2026 09:14

edgelessci and others added 5 commits August 19, 2026 10:15

dev-docs: update NVIDIA RIM IDs

3158093

nvidia-driver: 595.71.05 -> 610.57.04

33051fa

justfile: discover gpu types from cluster

252ff50

e2e: discover gpu types from cluster

6274730

tdx-measure: support b300

693e8c3

msanft added 6 commits August 19, 2026 10:15

kata/genpolicy: support b300

0cab088

treewide: fix outdated comments

79f572f

dev-docs: document GPU resource names

9e0c49f

upgrade-gpu-operator: recognize B300 PCI devices

2f650dc

e2e: test every discovered GPU model

7d2f738

e2e: support GPU models on separate nodes

5c51189

msanft force-pushed the msanft/treewide/b300 branch 2 times, most recently from d484143 to 4794cb8 Compare August 19, 2026 08:55

ci: update bm-tcb-specs for dgx-007

f91f9cb

msanft force-pushed the msanft/treewide/b300 branch from 4794cb8 to f91f9cb Compare August 19, 2026 09:16

Uh oh!

Conversation

msanft commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Aug 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charludo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charludo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 17, 2026

Do the documentation changes need to be backported?

Uh oh!

github-actions Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-08-19 09:17 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

msanft commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 17, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-08-19 09:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.