sdk: negotiate API version - #2568
Open
charludo wants to merge 2 commits into
Open
Conversation
charludo
force-pushed
the
ch/sdk-select-version
branch
from
August 4, 2026 13:10
ca623d6 to
3471eac
Compare
Collaborator
Author
|
@sespiros only requesting review on this one for now, since all other API PRs require it. |
charludo
force-pushed
the
ch/sdk-select-version
branch
from
August 10, 2026 10:37
3471eac to
67ac4ad
Compare
sespiros
requested changes
Aug 12, 2026
sespiros
left a comment
sespiros
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, did a pass and left a few comments.
sespiros
approved these changes
Aug 13, 2026
sespiros
left a comment
sespiros
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, all addressed. One leftover: since writeJSONError now sets status_code here, the handler test could assert the body field in this PR too (right now that assertion only comes with the next PR in the stack).
charludo
force-pushed
the
ch/sdk-select-version
branch
from
August 13, 2026 12:46
f48eb94 to
cd4bc47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.