-
Notifications
You must be signed in to change notification settings - Fork 339
docs: fix up incorrect upgrade advice for 3.5 -> 3.6 upgrade #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alam0rt
wants to merge
1
commit into
etcd-io:main
Choose a base branch
from
alam0rt:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,19 +21,19 @@ Before upgrading to 3.6, make sure that [all of your 3.5 members are updated to | |
|
|
||
| #### V2 Store | ||
|
|
||
| **NOTE:** If the `--enable-v2` flag is not configured or is set to false, no further action is required. | ||
|
|
||
| If `--enable-v2` or the environment variable `ETCD_ENABLE_V2="true"` **is** configured, additional steps are required to handle the v2store data: | ||
| {{% alert title="Important" color="warning" %}} | ||
| Is it possible that custom data exists in v2store despite v2store not being enabled. Before upgrading to 3.6, make sure that you run the `etcdutl check v2store` utility as it prevent 3.6 running. | ||
| {{% /alert %}} | ||
|
|
||
| 1. If there is data in the v2store that needs to be migrated to the v3store, follow the [v2 migration guide](../../../v3.4/op-guide/v2-migration/) to migrate the data. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is recommended since we'd need to downgrade to 3.4 right? |
||
|
|
||
| 2. Remove the `--enable-v2` flag and the `ETCD_ENABLE_V2="true"` environment variable. | ||
| 2. Remove the `--enable-v2` flag and the `ETCD_ENABLE_V2="true"` environment variable if present. | ||
|
|
||
| 3. Run the command `etcdutl check v2store` to verify whether the v2store contains any non-membership (custom) data. If no custom data is present, no further action is required. | ||
|
|
||
| 4. If custom data is detected in the v2store, apply the following workaround to remove the legacy data: | ||
|
|
||
| - Add the flag `--snapshot-count=1` to each etcd instnace that contains custom data in the v2store. | ||
| - Add the flag `--snapshot-count=1` to each etcd instance that contains custom data in the v2store. | ||
| - Restart the etcd instances. | ||
| - Remove the `--snapshot-count=1` flag from (or restore to its original value, if applicable) from all etcd instances. | ||
| - Restart the etcd instances again. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is true because I am experiencing it as we speak haha. Stuck on 3.5 with v2store data. Compounded by not being able to tolerate downtime + v2 API not being accessible etcd-io/etcd#21249
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to understand the issue you're hitting better, because all of the v2store data issues were supposed to be fixed.