Feature/#25 - Add command line option --script-languages by kratz00 · Pull Request #28 · exasol/pytest-slc

kratz00 · 2026-06-12T06:17:26Z

Fixes #25

tkilias · 2026-06-25T06:51:34Z

+    """
+    The operation will be skipped if SCRIPT_LANGUAGES_OPTION is defined.
+    """
+    if request.config.getoption(SCRIPT_LANGUAGES_OPTION):


we need a test for this interaction

tkilias · 2026-06-25T06:56:51Z

    result.assert_outcomes(passed=2, skipped=0)
-
-
-def test_pytest_slc_skip(pytester):


got moved to test/integration/skip_test.py

tkilias · 2026-06-25T06:59:53Z

+pytest_plugins = ["pytester"]
+
+
+def test_empty_value_for_script_languages_raises_wrapper(pytester):


we need another test when the option is not set at all, how the script_languages fixtures react

kratz00 · 2026-07-02T11:22:56Z

@codex

chatgpt-codex-connector · 2026-07-02T11:22:59Z

To use Codex here, create a Codex account and connect to github.

kratz00 · 2026-07-02T11:24:49Z

@chatgpt-codex-connector

chatgpt-codex-connector · 2026-07-02T11:24:55Z

To use Codex here, create a Codex account and connect to github.

kratz00 · 2026-07-02T11:42:10Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd40abf231

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-02T11:45:20Z

+        pyexasol_connection_, LanguageActivationLevel.Session
+    )
+    set_script_languages(pyexasol_connection_, script_languages_)
+    yield


Ensure script languages are restored after failures

When a test using activate_script_languages_for_module or activate_script_languages_for_session fails or errors, contextlib throws that exception into this bare yield, so the reset call after it is skipped. That leaves the shared pyexasol_connection session configured with the override for later tests or teardown; wrap the yield in try/finally so the original SCRIPT_LANGUAGES value is always restored.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector In a yield fixture, the code after the yield is always executed as teardown, even if the test fails or raises an exception.

@codex address that feedback

To use Codex here, create an environment for this repo.

@codex address that feedback

Summary

Wrapped activate_script_languages teardown in a try/finally block so the previous SCRIPT_LANGUAGES value is restored even when the context body raises. exasol/pytest_slc/init.pyL225-L230

Added a unit test that exercises an exception inside activate_script_languages and verifies the original script language setting is restored. test/unit/script_languages_unit_test.pyL8-L29

Committed the changes on the current branch with commit 78482ce and created a PR titled “Fix script language restoration after context errors”.

Testing

✅ poetry run python -m black --target-version py312 --check exasol/pytest_slc/__init__.py test/unit/script_languages_unit_test.py

✅ poetry run pytest test/unit

⚠️ poetry run pytest test/unit test/integration/script_languages_test.py — integration checks failed because local Docker/ITDE database startup is unavailable in this environment.

View task →

In a yield fixture, the code after the yield is always executed as teardown, even if the test fails or raises an exception. @codex address that feedback

Summary

Wrapped activate_script_languages teardown in a try/finally so direct context-manager usage restores the previous SCRIPT_LANGUAGES value even when the body raises. exasol/pytest_slc/init.pyL217-L230

Added a unit test that simulates an exception inside activate_script_languages and verifies the temporary value is reset to the previous setting. test/unit/script_languages_unit_test.pyL14-L31

Committed the changes on the current branch with commit 9204c47 and created a PR titled “Fix script language restoration after context errors”.

Testing

✅ poetry run python -m black --target-version py310 --check exasol/pytest_slc/__init__.py test/unit/script_languages_unit_test.py

✅ poetry run pytest test/unit

View task →

kratz00 · 2026-07-02T14:57:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a096feafa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-02T15:03:16Z

+        pyexasol_connection_, LanguageActivationLevel.Session
+    )
+    set_script_languages(pyexasol_connection_, script_languages_)
+    yield


Restore script languages from a finally block

When callers use activate_script_languages directly as a context manager and the body raises, that exception is thrown back at this yield, so the reset on the next line is skipped and the shared pyexasol_connection can keep the temporary SCRIPT_LANGUAGES value for later tests. Wrap the yield in try/finally so failing UDF tests do not contaminate the rest of the run.

Useful? React with 👍 / 👎.

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

sonarqubecloud · 2026-07-07T11:51:34Z

Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

kratz00 temporarily deployed to manual-approval June 12, 2026 06:17 — with GitHub Actions Inactive

kratz00 temporarily deployed to manual-approval June 12, 2026 07:38 — with GitHub Actions Inactive

kratz00 force-pushed the feature/#25-slc-cmdline branch from 62fe971 to ee4237b Compare June 12, 2026 07:57

kratz00 temporarily deployed to manual-approval June 12, 2026 07:57 — with GitHub Actions Inactive

kratz00 force-pushed the feature/#25-slc-cmdline branch from ee4237b to e0019d2 Compare June 12, 2026 08:15

kratz00 temporarily deployed to manual-approval June 12, 2026 08:15 — with GitHub Actions Inactive

kratz00 force-pushed the feature/#25-slc-cmdline branch from e0019d2 to 6ebedfd Compare June 12, 2026 08:20

kratz00 temporarily deployed to manual-approval June 12, 2026 08:20 — with GitHub Actions Inactive

kratz00 force-pushed the feature/#25-slc-cmdline branch from 6ebedfd to ed55c55 Compare June 12, 2026 08:28

kratz00 temporarily deployed to manual-approval June 12, 2026 08:29 — with GitHub Actions Inactive

kratz00 temporarily deployed to manual-approval June 12, 2026 08:54 — with GitHub Actions Inactive

exasol deleted a comment from sonarqubecloud Bot Jun 12, 2026

kratz00 changed the title ~~Feature/#25 slc cmdline~~ Feature/#25 - Add command line option --script-languages Jun 19, 2026

kratz00 temporarily deployed to manual-approval June 22, 2026 09:09 — with GitHub Actions Inactive

kratz00 force-pushed the feature/#25-slc-cmdline branch from 3e7b671 to dd40abf Compare June 25, 2026 05:50

kratz00 temporarily deployed to manual-approval June 25, 2026 05:50 — with GitHub Actions Inactive

tkilias reviewed Jun 25, 2026

View reviewed changes

Comment thread exasol/pytest_slc/__init__.py

tkilias reviewed Jun 25, 2026

View reviewed changes

Comment thread test/integration/pytester/test_script_languages_onprem.py

tkilias reviewed Jun 25, 2026

View reviewed changes

Comment thread exasol/pytest_slc/__init__.py

tkilias reviewed Jun 25, 2026

View reviewed changes

kratz00 closed this Jul 2, 2026

kratz00 reopened this Jul 2, 2026

kratz00 requested a deployment to manual-approval July 2, 2026 09:37 — with GitHub Actions Waiting

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

kratz00 requested a deployment to manual-approval July 2, 2026 14:53 — with GitHub Actions Waiting

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

kratz00 requested a deployment to manual-approval July 3, 2026 12:23 — with GitHub Actions Waiting

kratz00 added 7 commits July 7, 2026 13:28

Added command line option '--script-languages' (fixes #25)

7e551c5

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Renamed unit test to fit our cookiecutter template

24c1b6b

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Added implementation + integration tests for #25

b199e35

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Added activate_script_languages_for_function

3115ee9

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Added comment - we skip SAAS testing

5f7df82

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Added test to verify script_languages is reset when leaving scope

517ae8c

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

Moved/Renamed module after merge with 'main' branch.

81fe648

Signed-off-by: Steffen Pankratz <steffen.pankratz@exasol.com>

kratz00 force-pushed the feature/#25-slc-cmdline branch from 20bae72 to 81fe648 Compare July 7, 2026 11:49

kratz00 requested a deployment to manual-approval July 7, 2026 11:49 — with GitHub Actions Waiting

		result.assert_outcomes(passed=2, skipped=0)


		def test_pytest_slc_skip(pytester):

		pytest_plugins = ["pytester"]


		def test_empty_value_for_script_languages_raises_wrapper(pytester):

Uh oh!

Conversation

kratz00 commented Jun 12, 2026

Uh oh!

Uh oh!

Uh oh!

tkilias Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tkilias Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

tkilias Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

kratz00 commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 2, 2026

Uh oh!

kratz00 commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 2, 2026

Uh oh!

kratz00 commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

kratz00 Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kratz00 Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

kratz00 Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

kratz00 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

kratz00 commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 7, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kratz00 Jul 2, 2026 •

edited

Loading