Skip to content

refactor(locale): rename ne to en_NP#3828

Open
ST-DDT wants to merge 1 commit into
nextfrom
refactor/locale/rename-ne
Open

refactor(locale): rename ne to en_NP#3828
ST-DDT wants to merge 1 commit into
nextfrom
refactor/locale/rename-ne

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented Apr 28, 2026

@ST-DDT ST-DDT added this to the v10.x milestone Apr 28, 2026
@ST-DDT ST-DDT self-assigned this Apr 28, 2026
@ST-DDT ST-DDT requested a review from a team as a code owner April 28, 2026 19:51
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions deprecation A deprecation was made in the PR labels Apr 28, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a34a2e8
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69f10fcd845f2f000853e9e5
😎 Deploy Preview https://deploy-preview-3828.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.81%. Comparing base (f286dfd) to head (a34a2e8).
⚠️ Report is 18 commits behind head on next.

Files with missing lines Patch % Lines
src/locale/ne.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3828      +/-   ##
==========================================
- Coverage   98.90%   98.81%   -0.10%     
==========================================
  Files         899      900       +1     
  Lines        3113     3116       +3     
  Branches      574      574              
==========================================
  Hits         3079     3079              
- Misses         30       33       +3     
  Partials        4        4              
Files with missing lines Coverage Δ
src/locale/en_NP.ts 100.00% <100.00%> (ø)
src/locale/index.ts 100.00% <ø> (ø)
src/locales/en_NP/company/index.ts 100.00% <ø> (ø)
src/locales/en_NP/index.ts 100.00% <100.00%> (ø)
src/locales/en_NP/internet/index.ts 100.00% <ø> (ø)
src/locales/en_NP/location/index.ts 100.00% <ø> (ø)
src/locales/en_NP/metadata.ts 100.00% <100.00%> (ø)
src/locales/en_NP/person/index.ts 100.00% <ø> (ø)
src/locales/en_NP/phone_number/format/index.ts 100.00% <ø> (ø)
src/locales/en_NP/phone_number/index.ts 100.00% <ø> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92
Copy link
Copy Markdown
Member

This is a major breaking change, is it? I think this needs to wait for v11.
Similar as we did here: https://v9.fakerjs.dev/guide/upgrading#locale-aliases

@ST-DDT
Copy link
Copy Markdown
Member Author

ST-DDT commented Apr 29, 2026

This is a major breaking change, is it?

Not yet. This only deprecates the old locale.

import { faker } from '@faker-js/faker/locale/ne'"

still works.

The actually breaking change is the removal of the old alias.

Or should we rename it in v11 without prior deprecation?

@Shinigami92
Copy link
Copy Markdown
Member

Maybe just plan it in for v11, that way we have one commit/noise less (also for the customer facing changelog)

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ne locale is not in Nepali

2 participants