refactor(locale): rename ne to en_NP#3828
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3828 +/- ##
==========================================
- Coverage 98.90% 98.81% -0.10%
==========================================
Files 899 900 +1
Lines 3113 3116 +3
Branches 574 574
==========================================
Hits 3079 3079
- Misses 30 33 +3
Partials 4 4
🚀 New features to boost your workflow:
|
|
This is a major breaking change, is it? I think this needs to wait for v11. |
Not yet. This only deprecates the old locale. import { faker } from '@faker-js/faker/locale/ne'"still works. The actually breaking change is the removal of the old alias. Or should we rename it in v11 without prior deprecation? |
|
Maybe just plan it in for v11, that way we have one commit/noise less (also for the customer facing changelog) |
Fixes #3655