Skip to content

fix(helpers): lazy results in fake#3852

Open
ST-DDT wants to merge 1 commit into
nextfrom
fix/helpers/eval/lazy-results
Open

fix(helpers): lazy results in fake#3852
ST-DDT wants to merge 1 commit into
nextfrom
fix/helpers/eval/lazy-results

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented May 20, 2026

I noticed with some constelations of lazy locale data, that properties fail to resolve.
This PR fixes this by eagerly evaluating the lazy functions before accessing the property within.

@ST-DDT ST-DDT added this to the v10.x milestone May 20, 2026
@ST-DDT ST-DDT requested review from a team May 20, 2026 19:56
@ST-DDT ST-DDT self-assigned this May 20, 2026
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels May 20, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ba355ec
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a0e11e7bb35840007e219e1
😎 Deploy Preview https://deploy-preview-3852.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.91%. Comparing base (e72fd7c) to head (ba355ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3852   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         905      905           
  Lines        3146     3146           
  Branches      581      581           
=======================================
  Hits         3112     3112           
  Misses         30       30           
  Partials        4        4           
Files with missing lines Coverage Δ
src/modules/helpers/eval.ts 95.65% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants