[in_app_purchase_android] Add showInAppMessages support (#107412)

[fingerart]

As mentioned in #107412, a new native feature (showInAppMessages) has been added.

final androidPlatformAddition = InAppPurchase.instance.getPlatformAddition<InAppPurchaseAndroidPlatformAddition>();
final result = await androidPlatformAddition.showInAppMessages();

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request adds support for the showInAppMessages API from the Google Play Billing Library. This includes defining the new API in Pigeon, implementing it on the Android native side, adding Dart wrappers, and updating the example app to demonstrate its usage. Tests for the new functionality have also been added.

[fingerart]

@stuartmorgan-g @GaryQian What else do I need to do?

[stuartmorgan-g]

@fingerart You need to wait for a review, which as our docs explain takes up to a couple of weeks.

[fingerart]

There are 6 failed checks, what do I need to do about it?

[stuartmorgan-g]

There are 6 failed checks, what do I need to do about it?

You can see the task output by going to View details -> View more details on flutter-dashboard -> stdout.

In this case they are all analyzer failures, which should trivially show up locally in any IDE configured to read repo-local analysis options.

[fingerart]

I have fixed the error checking item.

[gmackall]

Mostly lgtm, one question about future proofing re: the categories of message to show.

Also, it would be good to add a test to packages/in_app_purchase/in_app_purchase_android/test/in_app_purchase_android_platform_addition_test.dart as the other methods of in_app_purchase_android_platform_addition.dart are also tested there

something like

  group('showInAppMessages', () {
    test('showInAppMessages success', () async {
      const expected = InAppMessageResultWrapper(
        responseCode: InAppMessageResponse.subscriptionStatusUpdated,
        purchaseToken: 'dummy purchase token',
      );

      when(mockApi.showInAppMessages()).thenAnswer(
        (_) async => PlatformInAppMessageResult(
          responseCode: PlatformInAppMessageResponse.subscriptionStatusUpdated,
          purchaseToken: expected.purchaseToken,
        ),
      );

      final InAppMessageResultWrapper result =
          await iapAndroidPlatformAddition.showInAppMessages();

      expect(result, equals(expected));
    });
  });

[fingerart]

I added the showInAppMessages success test to packages/in_app_purchase/in_app_purchase_android/test/in_app_purchase_android_platform_addition_test.dart.

[gmackall]

lgtm, @bparrishMines would you like to do the secondary review?

[bparrishMines]

LGTM with a couple nits

[bparrishMines]

@fingerart This needs to merge in the main branch and handle merging the pigeon Kotlin update. This PR doesn't allow maintainers to make changes, so I can't do this for you.

[fingerart]

@bparrishMines I have updated to Kotlin.

[bparrishMines]

This looks good. I think the version bump got messed up with the kotlin merge. The pubspec version needs to updated along with my comments in the changelog.

[bparrishMines]

This should be more descriptive. Something like:

Suggested change

	* Add showInAppMessages support for Android platform.
	* Adds support to overlay billing related messages. See
	`InAppPurchaseAndroidPlatformAddition.showInAppMessages`.

[bparrishMines]

This needs to be moved to it's own version bump above this one. (e.g. 0.4.1)

[fingerart]

I generated the new version and changelog using update-release-info.

[fingerart]

@stuartmorgan-g Are there still any problems?

[stuartmorgan-g]

@fingerart I'm not sure why you are pinging me, since a) I'm not a reviewer for this PR, and b) the PR is clearly under active review.

Are you attempting to escalate your review because you didn't get a re-review within one business day of pushing an update? If so, please refer back to the documentation I linked you to originally about review expectations.