Skip to content

Reduce Liquid logic on china community page#12547

Merged
sfshaza2 merged 2 commits into
mainfrom
misc/simplify-use-in-china-page
Oct 14, 2025
Merged

Reduce Liquid logic on china community page#12547
sfshaza2 merged 2 commits into
mainfrom
misc/simplify-use-in-china-page

Conversation

@parlough

@parlough parlough commented Oct 14, 2025

Copy link
Copy Markdown
Member

This PR keeps the contents of the page mostly the same but reduces the use of complicated Liquid templating and includes. This does result in a little bit more duplication, but will be easier to maintain and keep compatible with future site infrastructure.

Staged: https://flutter-docs-prod--pr12547-misc-simplify-use-in-china-redp7hxp.web.app/community/china

@parlough parlough requested review from a team and sfshaza2 as code owners October 14, 2025 09:48
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Using Flutter in China community page by significantly reducing its reliance on complex Liquid templating and includes. The core content and instructions remain largely the same, but the implementation shifts from dynamic generation to more explicit, inlined content for each operating system. This strategic change prioritizes long-term maintainability and compatibility with evolving site infrastructure over highly abstracted templating.

Highlights

  • Simplified Liquid Logic: The pull request replaces complex Liquid includes and dynamic content generation with inlined, explicit content for each operating system, reducing the reliance on intricate templating.
  • Improved Maintainability: While introducing some content duplication, this change is designed to make the 'Using Flutter in China' page easier to maintain and more compatible with future site infrastructure.
  • Removed Dynamic Includes: Three Liquid include files (download-urls.md, os-settings.md, pub-settings.md) have been removed, with their functionality integrated directly into the main index.md file.
  • Explicit Platform Instructions: Detailed setup, download URL examples, and pub.dev access instructions for Windows, macOS, and Linux are now explicitly defined within index.md, eliminating the need for dynamic generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the China community page by removing complex Liquid templating in favor of duplicated but more maintainable hardcoded content. The changes are well-aligned with the stated goal. I've found some minor formatting issues in the new markdown content that would lead to incorrect rendering of ordered lists. My review comments provide details on how to fix them. Overall, this is a good improvement for maintainability.

Comment thread src/content/community/china/index.md
Comment thread src/content/community/china/index.md
@flutter-website-bot

flutter-website-bot commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit c8de86d):

https://flutter-docs-prod--pr12547-misc-simplify-use-in-china-redp7hxp.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! lgtm

@sfshaza2 sfshaza2 merged commit 1715c14 into main Oct 14, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the misc/simplify-use-in-china-page branch October 14, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants