Add some missing PWN 3.1 ILI maps#21
Open
jmccrae wants to merge 5 commits into
Open
Conversation
Member
|
This has several mappings from one ili to multiple synsets, which is not allowed:
I think we should also check the |
Remove all deprecations as these are not clear and some have been restored by other projects
Member
Author
|
I updated the branch so it has no duplicates and ILI to PWN 3.1 mappings are correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #16 some of the mappings that are reported as changed in PWN 3.1 are in fact not and have ILI codes. This PR fixes this by putting back all the matching synsets with the correct ILI