-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
root: Update PR template #22185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeshekDotDev
wants to merge
7
commits into
main
Choose a base branch
from
pr-template-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
root: Update PR template #22185
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
56f9f39
Update pr template
PeshekDotDev 6b10516
Update makefile in another PR
PeshekDotDev b0fd178
Apply suggestion from @dewi-tik
dewi-tik 641bb64
Merge branch 'main' into pr-template-update
dewi-tik 16a28f2
Merge branch 'main' into pr-template-update
PeshekDotDev 652a717
Merge branch 'main' into pr-template-update
PeshekDotDev b231de1
Merge branch 'main' into pr-template-update
PeshekDotDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,26 @@ | ||
| <!-- | ||
| 👋 Hi there! Welcome. | ||
| 👋 Hi there! Welcome. Please check the contributing guidelines: https://docs.goauthentik.io/docs/developer-docs/#how-can-i-contribute | ||
|
|
||
| Please check the Contributing guidelines: https://docs.goauthentik.io/docs/developer-docs/#how-can-i-contribute | ||
|
|
||
| ⚠️ IMPORTANT: Make sure you are opening this PR from a FEATURE BRANCH, not from your main branch! | ||
| If you opened this PR from your main branch, please close it and create a new feature branch instead. | ||
| For more information, see: https://docs.goauthentik.io/developer-docs/contributing/#always-use-feature-branches | ||
| ⚠️ Open this PR from a feature branch, not from main: https://docs.goauthentik.io/developer-docs/contributing/#always-use-feature-branches | ||
| --> | ||
|
|
||
| ## Details | ||
|
|
||
| <!-- | ||
| Explain what this PR changes, what the rationale behind the change is, if any new requirements are introduced or any breaking changes caused by this PR. | ||
|
|
||
| Ideally also link an Issue for context that this PR will close using `closes #` | ||
| --> | ||
| REPLACE ME | ||
|
|
||
| --- | ||
|
|
||
| ## Checklist | ||
| ### What does this PR change? | ||
|
|
||
| - [ ] Local tests pass (`ak test authentik/`) | ||
| - [ ] The code has been formatted (`make lint-fix`) | ||
| ### Why is this change needed? | ||
|
|
||
| If an API change has been made | ||
| ### How was this tested? | ||
|
|
||
| - [ ] The API schema and clients have been updated (`make gen`) | ||
| ### Linked issues | ||
|
|
||
| If changes to the frontend have been made | ||
| <!-- | ||
| Use `closes #N` to auto-close on merge. Use `refs #N` for related issues that this PR does not close. | ||
| --> | ||
|
|
||
| - [ ] The code has been formatted (`make web`) | ||
| --- | ||
|
|
||
| If applicable | ||
| ## Checklist | ||
|
|
||
| - [ ] The documentation has been updated | ||
| - [ ] The documentation has been formatted (`make docs`) | ||
| - [ ] The project has been linted, built, and tested (`make all`) | ||
| - [ ] The documentation has been updated and formatted (`make docs`) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.