ci: Fix Node script hang. Add timeouts to docker build, lint, and setup-node install steps - #22533
Closed
GirlBossRush wants to merge 3 commits into
Closed
ci: Fix Node script hang. Add timeouts to docker build, lint, and setup-node install steps#22533GirlBossRush wants to merge 3 commits into
GirlBossRush wants to merge 3 commits into
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22533 +/- ##
==========================================
+ Coverage 93.21% 93.24% +0.02%
==========================================
Files 1033 1033
Lines 60075 60075
Branches 400 400
==========================================
+ Hits 56001 56019 +18
+ Misses 4074 4056 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
if we're doing this, let's add timeouts to everything |
GirlBossRush
force-pushed
the
ci/timeout-stuck-builds
branch
from
May 21, 2026 15:27
de0f98d to
24666e0
Compare
GirlBossRush
changed the title
GirlBossRush
added
area:frontend
Surfaces hosted-runner/network hangs as prompt failures instead of letting jobs sit for GitHub's 6-hour default. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
GirlBossRush
force-pushed
the
ci/timeout-stuck-builds
branch
from
May 22, 2026 01:12
24666e0 to
bd4b415
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-91b07ef583d9e1ea70c93e8c4b6258b63f1b5374
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-91b07ef583d9e1ea70c93e8c4b6258b63f1b5374Afterwards, run the upgrade commands from the latest release notes. |
rissson
reviewed
May 22, 2026
| run: | #shell | ||
| node ./scripts/node/lint-lockfile.mjs | ||
| corepack npm ci | ||
| timeout 5m corepack npm ci |
Member
There was a problem hiding this comment.
Should this be a timeout on that step instead? If that's supported, I'm not 100% on that
| build: | ||
| name: Build ${{ inputs.image_arch }} | ||
| runs-on: ${{ inputs.runs-on }} | ||
| timeout-minutes: 30 |
Member
There was a problem hiding this comment.
I'd rather have one PR that fixes the hang, and then another big one that adds timeouts to everything
This was referenced Jun 2, 2026
Contributor
Author
|
Splitting this into two focused PRs per @rissson's review:
Closing in favor of those two. Thanks @rissson! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.exit(0)calls to scripts to drain logger.timeout-minutes: 30to_reusable-docker-build-single.yml(build job) and thelintmatrix inci-main.yml— both were relying on GitHub's 6-hour default.timeout-minutes: 5to the twocorepack npm cisteps in.github/actions/setup-nodeso a hung npm install surfaces as a real failure.