Introduce PdfExportService and platform interfaces#3758
Open
andreia-ferreira wants to merge 14 commits into
Open
Introduce PdfExportService and platform interfaces#3758andreia-ferreira wants to merge 14 commits into
andreia-ferreira wants to merge 14 commits into
Conversation
…at will handle the different steps
…to androidHostTest
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
andreia-ferreira
changed the title
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3758 +/- ##
============================================
+ Coverage 68.06% 68.11% +0.05%
+ Complexity 1612 1610 -2
============================================
Files 369 369
Lines 9534 9529 -5
Branches 1244 1246 +2
============================================
+ Hits 6489 6491 +2
+ Misses 2377 2368 -9
- Partials 668 670 +2
🚀 New features to boost your workflow:
|
shobhitagarwal1612
requested changes
May 30, 2026
| val images = imageProvider.load(request.qrContent, request.document.photoFilenames()) | ||
| try { | ||
| renderer.render(request.document, images, path) | ||
| } finally { |
Member
There was a problem hiding this comment.
If renderer.render() throws an exception (e.g. out of memory, disk full, etc.), a partially written or corrupted 0-byte file might be left on the disk. To prevent opening/sharing broken PDFs, please consider catching exceptions during rendering and delete the corrupted file. Then re-throw the exception so it can be handled upstream
Collaborator
Author
There was a problem hiding this comment.
thanks for catching this. Added the exception handling 👍
Comment on lines
+62
to
+63
| .map { it.filter(::isSafeFileChar) } | ||
| .filter { it.isNotBlank() } |
Member
There was a problem hiding this comment.
Will this work for other locales (e.g. japanese or arabic characters)?
Collaborator
Author
There was a problem hiding this comment.
good point, this would not work. I updated it so now characters from all languages are preserved
andreia-ferreira
requested a deployment
to
e2e-approval
GitHub Actions
Waiting
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3715
Introduces the scaffolding for PDF export of submission data. This is platform-independent and has the
PdfExportServiceas entry point. The provider/renderer/launcher interfaces will be implemented on the platform level on the next PR. This new code is part of a new KMP module:feature:pdfAdditionally, as a small cleanup, removed the jvm from the
core:uigradle config because otherwise all expect/actual logic would have to be also implemented on jvmMain. Also added androidLibrary target tocore:testingso that the fake testing classes are possible to be used by modules that contain that targetThis introduces no functionality changes.
@shobhitagarwal1612 PTAL?