Chore: fix experimental QueryData map initalizers #921
Merged
Conversation
ryantxu
requested review from
andresmgot,
oshirohugo,
toddtreece and
wbrowne
and removed request for
a team
toddtreece
reviewed
Mar 8, 2024
| body, err := json.Marshal(val) | ||
| if err != nil { | ||
| if err == nil { | ||
| _ = json.Unmarshal(body, &g.Datasource) |
Member
There was a problem hiding this comment.
should these unmarshal errors be handled/logged?
andresmgot
reviewed
Mar 11, 2024
Comment on lines
+233
to
+236
| ii, ok := v.(int) | ||
| if ok { | ||
| return float64(ii), nil | ||
| } |
Collaborator
There was a problem hiding this comment.
this is already covered in the lines just above
toddtreece
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#897 ignores the complex values when setting values via map. This fixes that error