fix: remove stale secrets datasource proxy routes - #1772
Open
mem wants to merge 1 commit into
Open
Conversation
The datasource proxy declared GET/PUT/POST/DELETE routes for api/v1alpha1/secrets, pointing at the Synthetic Monitoring API. These date back to the "intermediate secrets management" work and are no longer used: the app now reads and writes secrets directly through Grafana's App Platform secrets API (secret.grafana.app) via SecretsManagerClient added in 4af0d71, never through the datasource proxy. No TypeScript code references these routes. Drop the dead route declarations.
Script size changes
Totals
|
Contributor
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3a725cd. Configure here.
Contributor
Author
|
I need to hold this one until I get confirmation from a customer that they no longer need something or that they have switched to a different solution. |
Contributor
|
@mem do you know if we have that confirmation yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datasource proxy declared GET/PUT/POST/DELETE routes for api/v1alpha1/secrets, pointing at the Synthetic Monitoring API. These date back to the "intermediate secrets management" work and are no longer used: the app now reads and writes secrets directly through Grafana's App Platform secrets API (secret.grafana.app) via SecretsManagerClient added in 4af0d71, never through the datasource proxy. No TypeScript code references these routes.
Drop the dead route declarations.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: